gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Alex Hall	f5981606e1	(core) Make CONTAINS a function for consistency with mkpydocs etc. Summary: Having CONTAINS be a class is a pain, undoing that mistake now Test Plan: none needed Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2929	3 years ago
Alex Hall	f7a9638992	(core) CONTAINS() and summarising by ChoiceList columns with flattening Summary: Added CONTAINS 'function' which can be used in lookups Changed LookupMapColumn._row_key_map to use right=set so one row can have many keys when CONTAINS is used. Use CONTAINS to implement group column in summary table, while helper column in source table can reference and create multiple rows in summary table, especially when summarising by ChoiceList columns. Use itertools.product to generate all combinations of lookup keys and groupby values. cleanup Test Plan: Added python unit tests. Reviewers: dsagal Reviewed By: dsagal Subscribers: paulfitz, dsagal Differential Revision: https://phab.getgrist.com/D2900	3 years ago
Alex Hall	a9d5b4d5af	(core) Refactor Table.Record[Set] classes Summary: Dealing with some things that bothered and sometimes confused me: Make Table.Record[Set] provide the table argument automatically Remove the classes from UserTable because they're not used anywhere and the Table/UserTable distinction is already confusing. They're not documented for users and they don't show up in autocomplete. Remove RecordSet.Record because it was confusing me where that attribute was being set, but also this means .Record will work properly for users with columns named 'Record'. Test Plan: existing tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2913	3 years ago
George Gevoian	9592e3610b	(core) Add 'value' to trigger formula autocomplete Summary: API signature for autocomplete updated to add column ID, which is necessary for exposing correct types for 'value'. Test Plan: Unit tests. Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: jarek, alexmojaki Differential Revision: https://phab.getgrist.com/D2896	3 years ago
Alex Hall	305b133c59	(core) Remaining Python 3 compatibility changes Summary: Biggest change is turning everything to unicode Test Plan: The tests Reviewers: dsagal, paulfitz Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2875	3 years ago
Alex Hall	16f297a250	(core) Simple Python 3 compatibility changes Summary: Changes that move towards python 3 compatibility that are easy to review without much thought Test Plan: The tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2873	3 years ago
Dmitry S	9d6637458e	(core) For autocomplete suggestions in formulas, add links to suggestions we have documentation for. Summary: This is a hacky solution that unfortunately relies on internal workings of ACE autocomplete popups. I don't see a less hacky one if we stick with ACE autocomplete. Test Plan: Added a test case for links to test/nbrowser/Formulas.ts Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2610	4 years ago
Dmitry S	003029bf8a	(core) Improve suggestions for formula autocomplete Summary: - Make suggestions less case-sensitive (not entirely case-insensitive, but allow top-level suggestions to match in all-lowercase) - Add function signatures to suggestions for Grist functions. - Excel-like functions that are present but not implemented are no longer offered as suggestions. Test Plan: Added a test case on python side, and a browser test case for how suggestions are rendered and inserted. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2608	4 years ago

8 Commits (fb583f303a7db61a89dcefe26eb627ea5d99afe4)