6 Commits (faec8177abd50429f7292d2cb52bd4de8916ceed)

Author	SHA1	Message	Date
Alex Hall	116fb15eda	(core) Move most of the reference parsing code into common so that the server can use it ... Summary: Refactoring in preparation for parsing strings from the API. The plan is that the API code will only need to do a server-side version of the code in ViewFieldRec.valueParser (minus ReferenceUtils) which is quite minimal. Test Plan: Nothing extra here, I don't think it's needed. This stuff will get tested more in a future diff which changes the API. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3164	3 years ago
Alex Hall	064455b2f7	(core) Parsing pasted datetimes ... Summary: Add function parseDateTime which parses a string containing both date and time componenents, intended for parsing pasted strings. Add DateTimeParser subclass of ValueParser. Test Plan: Extended parseDate.ts and CopyPaste.ts tests. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3152	3 years ago
Alex Hall	0d460ac2d4	(core) Parsing pasted ChoiceLists ... Summary: Added ChoiceListParser capable of parsing JSON, CSVs, and other strings containing user-configured choices (e.g. separated by spaces) I got a little carried away here. It works, and I can't think of any bugs, but it's complicated enough that there could be hidden edge cases or difficulties maintaining it in the future. The advantage of the current method is that it should work well for ambiguous or poorly formatted inputs, e.g. choices separated only by spaces or choices containing commas which are not escaped/quoted properly. The code can be vastly simplified if we don't try to support that and require that users paste proper JSON or CSVs. Test Plan: Added a new file test/common/ChoiceListParser.ts with pure unit tests. Waiting for approval of the overall approach before adding to the nbrowser CopyPaste test. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3141	3 years ago
Alex Hall	d63da496a8	(core) Value parsing for refs, parsing data entry for numbers ... Summary: Handle reference columns in ViewFieldRec.valueParser. Extracted code for reuse from ReferenceEditor to look up values in the visible column. While I was at it, also extracted a bit of common code from ReferenceEditor and ReferenceListEditor into a new class ReferenceUtils. More refactoring could be done in this area but it's out of scope. Changed NTextEditor to use field.valueParser, which affects numeric and reference fields. In particular this means numbers are parsed on data entry, it doesn't change anything for references. Test Plan: Added more CopyPaste testing to test references. Tested entering slightly formatted numbers in NumberFormatting. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3094	3 years ago
Alex Hall	e58df5df5b	(core) ValueParser for Date columns ... Summary: Adds parseDateStrict function based on parseDate, uses it in DateParser subclass of ValueParser. Test Plan: Tweaked parseDate test to check parseDateStrict. Extended test in CopyPaste to test parsing dates as well as numbers. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3088	3 years ago
Alex Hall	99878c08ed	(core) Add ValueParser, use when pasting ... Summary: Add ValueParser file, base class, and subclasses for column types. Only NumericParser is used for now. Add valueParser field to ViewFieldRec. Use valueParser when parsing pasted text data in Grid and Detail views. Test Plan: Add test to nbrowser CopyPaste suite, copying into a numeric column with different currency and locale settings. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3082	3 years ago