5 Commits (f877f3859d61d73e73b89d3964140d2375de051c)

Author	SHA1	Message	Date
Alex Hall	f110ffdafd	(core) Follow chain of same-record links for getDefaultColValues ... Summary: When two widgets are linked by same-record linking, and the source of that link is also filter-linked, then it will pick up default values from its own filter-link source, but the same-record-link target didn't. This fixes that so that default values are filled in intuitively. Moved the logic of linkingState, linkingFilter, and getDefaultColValues from BaseView.js to LinkingState.ts and ViewSectionRec.ts. In particular getDefaultColValues is now a property of LinkingState which may be copied from the source view section for a same-record link. Note that `ViewSectionRec.linkingFilter` no longer uses `computerBuilder` and thus doesn't ignore dependencies inside LinkingState any more. I couldn't figure out how to make `linkingFilter` a `pureComputed` (otherwise I get recursion errors) that ignores dependencies. In any case, it's now important to have a dependency on `srcSection.linkingState()` for `getDefaultColValues` to work correctly, so I think this is for the best. Test Plan: Added a new nbrowser test and fixture. Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3238	3 years ago
Jarosław Sadziński	d08fdd772e	(core) Fixing bug with undoing page delation with a custom layout ... Summary: Fixing a bug: When removing a page with linked sections and then undoing, there are two JS errors raised: - flexSize is not a function - getter is not a function Test Plan: nbrowser tests Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3192	3 years ago
Alex Hall	de76cc48d1	(core) Move cursor to new record in link target when selecting new record in link source ... Summary: Update LinkingState._makeSrcCellGetter to account for 'new' Test Plan: Extended test in RightPanelSelectBy.ts Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3037	3 years ago
Alex Hall	29dd33a45c	(core) Add other direction of linking by reflist ... Summary: Allows selecting by a reflist in another table. This generalises cursor-linking with a ref column, but now it's filter linking. Added another case to LinkingState where the source column is a reflist to the target table, filtering by the id column. Updated convertQueryFromRefs and related functions to handle this since the id column has no column ref. In this case the string 'id' is used instead of a number. LinkingState also checks if the source value is a reflist and uses that as the list of filter values instead of a single-element list of the cell value. Indirect linking also works, where the source and target columns both are both references to the same table. This was the plan for a source reflist and target ref column. I was surprised to see it also works perfectly when both columns are reflists, and it filters rows where there's an intersection! Adding rows to the target section using the selected source record for default values is iffy. When filtering by row ID, there's no column for defaults, so the new row disappears. For a source reflist and target ref, the first value of the reflist is the default, which is okayish. When both are reflists, the full source reflist is the default for the target column. This seems like a bit much but just using the first value seems a bit arbitrary when there's room for all of them? While doing all this I noticed an unrelated bug which I fixed as I was refactoring. Previously cursor linking based on a reference column did not update the cursor in the link target when the value of the selected reference cell changed. Now cursor linking uses a floating row model like most other cases to observe the value correctly. Test Plan: Extended SelectByRefList test and fixture, added previously failing test to RightPanelSelectBy. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3004	3 years ago
Alex Hall	7465af8ce8	(core) Port LinkingState.js to TypeScript ... Summary: Converted LinkingState from constructor function to class. Test Plan: no Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2997	3 years ago