gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Dmitry S	05edd80ce7	(core) Finish fixing default cell color: error cells should also use black color. Summary: Previous diff (https://phab.getgrist.com/D2736) broke a test, which I assumed was unrelated, but should have checked. In fact, a few tests were changed to pass with the changed default color (although no such change was planned). This diff reverts those changes, and reverts also the change to error cells, so that their text is also black again. Test Plan: Checked affected tests. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2737	4 years ago
Dmitry S	08fe240bcf	(core) Restore default text color for Grist cells to black Summary: Diff https://phab.getgrist.com/D2720 inadvertently changed the default color of text in cells from black to #333 (inherited from bootstrap's default for <body>). This change reverts the default back to black. Test Plan: Checked manually. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2736	4 years ago
Cyprien P	890a8709f3	(core) Making cells colors effective also in Card and Card List views Summary: . Makes cell color work well in comparison mode . Do not apply cell color to the add new row . Allow to change color for all widget (including changing color for the checkbox and the switch widget) . Fix an issue that was setting color to black when opening the picker . Do not apply color to invalid cell Test Plan: . Added nbrowser/CellColor Reviewers: paulfitz, dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2720	4 years ago
Paul Fitzpatrick	c387fc4bce	(core) hide long sequences of unchanged rows in diffs Summary: It can be hard to find changes, even when highlighted, in a table with many rows. This diff replaces long sequences of unchanged rows with a row containing "..."s. With daff, I found that it is important to do this for sequences of unchanged columns also, but not tackling that yet. Test Plan: added test Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2666	4 years ago
Paul Fitzpatrick	c67966775b	(core) simplify document comparison code, and flesh out diff with local changes Summary: With recent changes to action history, we can now remove the temporary `finalRowContent` field from change details, since all the information we need is now in the ActionSummary. We also now have more information about the state of the common ancestor, which previously we could not get either from ActionSummary or from `finalRowContent`. We take advantage of that to flesh out rendering differences where there are some changes locally and some changes remotely. There's still a lot more to do, this is just one step. I have added a link to the UI for viewing the comparison. I wouldn't want to advertise that link until diffs are robust to name changes. Test Plan: added test, updated tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2658	4 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago

6 Commits (e55fba24e717ed4a6d121d8ab3398c8e8317fe3d)