gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
George Gevoian	08b1286f4f	(core) Add column matching to Importer Summary: The Importer dialog is now maximized, showing additional column matching options and information on the left, with the preview table shown on the right. Columns can be mapped via a select menu listing all source columns, or by clicking a formula field next to the menu and directly editing the transform formula. Test Plan: Browser tests. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3096	3 years ago
Alex Hall	a64fb105e3	(core) Use GristObjCode in CellValue Summary: Makes type checking a bit stronger Test Plan: it just has to compile Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3065	3 years ago
George Gevoian	62db263d1f	(core) Add diff preview to Importer Summary: Updates the preview table in Importer to show a diff of changes when importing into an existing table and updating existing records. Test Plan: Browser tests. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3060	3 years ago
George Gevoian	e1780e4f58	(core) Migrate import code from data engine to Node Summary: Finishing imports now occurs in Node instead of the data engine, which makes it possible to import into on-demand tables. Merging code was also refactored and now uses a SQL query to diff source and destination tables in order to determine what to update or add. Also fixes a bug where incremental imports involving Excel files with multiple sheets would fail due to the UI not serializing merge options correctly. Test Plan: Browser tests. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3046	3 years ago
Alex Hall	7f1f8fc9e6	(core) Linking summary tables grouped by list columns Summary: Prefix keys of `LinkingState.filterColValues` with `_contains:` when the source column is a ChoiceList or ReferenceList. This is parsed out to make a boolean `isContainsFilter` which is kept in each value of `QueryRefs.filterTuples` (previously `filterPairs`). Then when converting back in `convertQueryFromRefs` we construct `Query.contains: {[colId: string]: boolean}`. Finally `getFilterFunc` uses `Query.contains` to decide what kind of filtering to do. This is not pretty, but the existing code is already very complex and it was hard to find something that wouldn't require touching loads of code just to make things compile. Test Plan: Added a new nbrowser test and fixture, tests that selecting a source table by summary tables grouped by a choicelist column, non-list column, and both all filter the correct data. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2940	3 years ago
Dmitry S	8156f957b3	(core) Fix 'table not found' error when converting columns in the presence of per-row ACL rules. Summary: Column conversions involve changes to metadata tables such as _grist_Tables_column. When fetched (from GranularAccess), ExpandedQuery used to fail with 'table not found' because there is no metadata for metadata tables. This diff limits the need for metadata in ExpandedQuery to when it's actually needed (to implmement some formulas for on-demand tables), which no longer interferes with GranularAccess. Test Plan: Added a test case that reproduces the issue before the fix. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2729	4 years ago
Dmitry S	e2226c3ab7	(core) Store formula values in DB, and include them into .stored/.undo fields of actions. Summary: - Introduce a new SQLiteDB migration, which adds DB columns for formula columns - Newly added columns have the special ['P'] (pending) value in them (in order to show the usual "Loading..." on the first load that triggers the migration) - Calculated values are added to .stored/.undo fields of user actions. - Various changes made in the sandbox to include .stored/.undo in the right order. - OnDemand tables ignore stored formula columns, replacing them with special SQL as before - In particular, converting to OnDemand table leaves stale values in those columns, we should maybe clean those out. Some tweaks on the side: - Allow overriding chai assertion truncateThreshold with CHAI_TRUNCATE_THRESHOLD - Rebuild python automatically in watch mode Test Plan: Fixed various tests, updated some fixtures. Many python tests that check actions needed adjustments because actions moved from .stored to .undo. Some checks added to catch situations previously only caught in browser tests. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2645	4 years ago
Paul Fitzpatrick	5ef889addd	(core) move home server into core Summary: This moves enough server material into core to run a home server. The data engine is not yet incorporated (though in manual testing it works when ported). Test Plan: existing tests pass Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2552	4 years ago

8 Commits (dc52c7fe0a1e248c443a24fb81f4b3f0c509e17c)