gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
George Gevoian	a294eefdff	(core) Update HomeIntro.ts to check for either login page Summary: The "Sign In" button can either redirect you to the Cognito login page or the Grist sign-up page, depending on whether you've logged in before. Since the HomeIntro tests can either be run as part of a full deployment test suite, or individually, the test could redirect you to both types of login pages. Test Plan: N/A (fixing test) Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D3291	3 years ago
George Gevoian	8f1889d2d7	(core) Fix staging test that would timeout Summary: Removes code from simulateLogin that's no longer needed, and increases the timeout on the util function that checks if we're on the Grist sign-up page. Test Plan: N/A (fixing test) Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D3287	3 years ago
George Gevoian	ac910389bc	(core) Make login URL regexes more specific Summary: This should resolve some staging test failures. The previous regexes weren't quite specific enough, so random parts of a URL that had traces of the real login URLs were causing isOnLoginPage() and isOnGristLoginPage() to return true instead of false. Test Plan: N/A (fixing tests) Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3283	3 years ago
George Gevoian	481122b4d3	(core) Fix failing login tests Summary: The rollout of the new sign-up page on prod caused a few tests that previously expected to be on the Cognito sign-up page to fail. Test Plan: N/A (fixing failing tests). Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D3279	3 years ago
George Gevoian	99f3422217	(core) Add new Grist sign-up page Summary: Available at login.getgrist.com/signup, the new sign-up page includes similar options available on the hosted Cognito sign-up page, such as support for registering with Google. All previous redirects to Cognito for sign-up should now redirect to the new Grist sign-up page. Login is still handled with the hosted Cognito login page, and there is a link to go there from the new sign-up page. Test Plan: Browser, project and server tests. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3249	3 years ago
Paul Fitzpatrick	d99db8d016	(core) move more tests to grist-core Summary: * Tie build and run-time docker base images to a consistent version (buster) * Extend the test login system activated by GRIST_TEST_LOGIN to ease porting tests that currently rely on cognito (many) * Make org resets work in absence of billing endpoints * When in-memory session caches are used, add missing invalidation steps * Pass org information through sign-ups/sign-ins more carefully * For CORS, explicitly trust GRIST_HOST origin when set * Move some fixtures and tests to core, focussing on tests that cover existing failures or are in the set of tests run on deployments * Retain regular `test` target to run the test suite directly, without docker * Add a `test:smoke` target to run a single simple test without `GRIST_TEST_LOGIN` activated * Add a `test:docker` target to run the tests against a grist-core docker image - since tests rely on certain fixture teams/docs, added `TEST_SUPPORT_API_KEY` and `TEST_ADD_SAMPLES` flags to ease porting The tests ported were `nbrowser` tests: `ActionLog.ts` (the first test I tend to port to anything, out of habit), `Fork.ts` (exercises a lot of doc creation paths), `HomeIntro.ts` (a lot of DocMenu exercise), and `DuplicateDocument.ts` (covers a feature known to be failing prior to this diff, the CORS tweak resolves it). Test Plan: Manually tested via `buildtools/build_core.sh`. In follow up, I want to add running the `test:docker` target in grist-core's workflows. In jenkins, only the smoke test is run. There'd be an argument for running all tests, but they include particularly slow tests, and are duplicates of tests already run (in different configuration admittedly), so I'd like to try first just using them in grist-core to gate updates to any packaged version of Grist (the docker image currently). Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D3176	3 years ago
Jarosław Sadziński	bb55422d9c	(core) Fixing UserProfile test that fails randomly Summary: UserProfile test fails randomly which is caused by the AccountWidget that loads its data asonchrynously. Test Plan: Existing tests Reviewers: dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D2964	3 years ago
Dmitry S	1605e18f66	(core) Enable auto triggering of Welcome Tour, and various improvements. Summary: - Add showGristTour preference, and trigger tour automatically. - Tour is only triggered for new and anonymous users on a personal org, with edit permission. - Automatically open the right panel at tour start. - Don't show tours on mobile, since that's not ready (popups are cut off and can't be dismissed) - Cancel previous tour if a new one is somehow started. - Remove #repeat- trigger hash tags from the URL when the tour starts. - Ensure Help Center popup is positioned even when left panel is collapsed. - Polish up the content of the last two cards in the tour. Test Plan: Added test case for triggering and opening right panel. Reviewers: alexmojaki, paulfitz Reviewed By: alexmojaki Differential Revision: https://phab.getgrist.com/D2955	3 years ago
Paul Fitzpatrick	9f234b758d	(core) freshen grist-core build Summary: * adds a smoke test to grist-core * fixes a problem with highlight.js failing to load correctly * skips survey for default user * freshens docker build Utility files in test/nbrowser are moved to core/test/nbrowser, so that gristUtils are available there. This increased the apparent size of the diff as "./" import paths needed replacing with "test/nbrowser/" paths. The utility files are untouched, except for the code to start a server - it now has a small grist-core specific conditional in it. Test Plan: adds test Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2768	4 years ago

9 Commits (c2070877b66accb9bcdefcd269388d8197ed02f2)