4 Commits (b8f75997cad0216d9046b8ab0b2315fa397bd238)

Author	SHA1	Message	Date
Dmitry S	faa0d9988e	(core) When changing a table for a page widget, unset widget-linking to avoid invalid values. ... Summary: Previously, using "Change Widget" allowed one to change the underlying table, but would keep the linking settings. This could allow invalid settings which would sometimes lead to JS errors. These manifested in production as "UserError: Query error: n is not a function". - Unset linking settings in this case, to avoid invalid values. - In case invalid values are encountered (e.g. saved previously), treat them as unset, to avoid JS errors. - If an error does occur, report it with a stack trace. Also, for testing, added 'selectBy' option to gristUtils helpers for using page-widget-picker. Test Plan: Added test cases for resetting linking, and for ignoring invalid link settings. Reviewers: alexmojaki Reviewed By: alexmojaki Differential Revision: https://phab.getgrist.com/D2993	3 years ago
George Gevoian	f613b68a9e	(core) Fix widget loading spinner title ... Summary: The loading spinner would always display 'Building Table widget' when creating or changing a widget. This fixes the title to reflect the selected widget type. Test Plan: Updated existing browser tests to verify the loading spinner title includes the correct widget type. Reviewers: dsagal, paulfitz Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2863	3 years ago
Dmitry S	d1c1416d78	(core) Add rules to eslint to better match our coding conventions. ... Summary: We used tslint earlier, and on switching to eslint, some rules were not transfered. This moves more rules over, for consistent conventions or helpful warnings. - Name private members with a leading underscore. - Prefer interface over a type alias. - Use consistent spacing around ':' in type annotations. - Use consistent spacing around braces of code blocks. - Use semicolons consistently at the ends of statements. - Use braces around even one-liner blocks, like conditionals and loops. - Warn about shadowed variables. Test Plan: Fixed all new warnings. Should be no behavior changes in code. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2831	3 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core ... Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago