3 Commits (b6dd066b7f3ba02dff523c97c8647b887865ce36)

Author	SHA1	Message	Date
Alex Hall	de76cc48d1	(core) Move cursor to new record in link target when selecting new record in link source ... Summary: Update LinkingState._makeSrcCellGetter to account for 'new' Test Plan: Extended test in RightPanelSelectBy.ts Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3037	3 years ago
Alex Hall	29dd33a45c	(core) Add other direction of linking by reflist ... Summary: Allows selecting by a reflist in another table. This generalises cursor-linking with a ref column, but now it's filter linking. Added another case to LinkingState where the source column is a reflist to the target table, filtering by the id column. Updated convertQueryFromRefs and related functions to handle this since the id column has no column ref. In this case the string 'id' is used instead of a number. LinkingState also checks if the source value is a reflist and uses that as the list of filter values instead of a single-element list of the cell value. Indirect linking also works, where the source and target columns both are both references to the same table. This was the plan for a source reflist and target ref column. I was surprised to see it also works perfectly when both columns are reflists, and it filters rows where there's an intersection! Adding rows to the target section using the selected source record for default values is iffy. When filtering by row ID, there's no column for defaults, so the new row disappears. For a source reflist and target ref, the first value of the reflist is the default, which is okayish. When both are reflists, the full source reflist is the default for the target column. This seems like a bit much but just using the first value seems a bit arbitrary when there's room for all of them? While doing all this I noticed an unrelated bug which I fixed as I was refactoring. Previously cursor linking based on a reference column did not update the cursor in the link target when the value of the selected reference cell changed. Now cursor linking uses a floating row model like most other cases to observe the value correctly. Test Plan: Extended SelectByRefList test and fixture, added previously failing test to RightPanelSelectBy. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D3004	3 years ago
Alex Hall	7465af8ce8	(core) Port LinkingState.js to TypeScript ... Summary: Converted LinkingState from constructor function to class. Test Plan: no Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2997	3 years ago