3 Commits (9d1cc89dc981cb3d52fb072198c50a1238b7b20b)

Author	SHA1	Message	Date
Alex Hall	16f297a250	(core) Simple Python 3 compatibility changes ... Summary: Changes that move towards python 3 compatibility that are easy to review without much thought Test Plan: The tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2873	3 years ago
Dmitry S	ec023a3ba6	(core) Fix another cause of inconsistency that can be triggered by bad DocActions. ... Summary: An incorrect DocAction (as possible from an Undo of a non-last action) could cause RemoveRecord on an already missing record. This used to create an invalid undo, and wreak havoc when a series of DocActions later fails and needs to be reverted. To fix, consider RemoveRecord of a missing record to be a no-op. Test Plan: Includes a new test case that triggers the problem. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2717	4 years ago
Dmitry S	14cdd47675	(core) When checking for metadata consistency, check for stray column records too ... Summary: Currently, an undo of a non-last action can leave the doc in an inconsistent state. For example, it may remove a table, but fail to remove all columns of it from metadata. We normally check that schema corresponds to metadata, but stray columns were not visible to this check, and instead caused later table additions to fail. This diff fixes the check to fail the action that causes stray columns, and to restore the doc to a consistent state. Note that this only handles schema-metadata inconsistencies, but an undo of a non-last action can easily create other surprises. Test Plan: Added a test case that triggered inconsistency before, and now triggers a failed undo. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2715	4 years ago