gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Alex Hall	7f1f8fc9e6	(core) Linking summary tables grouped by list columns Summary: Prefix keys of `LinkingState.filterColValues` with `_contains:` when the source column is a ChoiceList or ReferenceList. This is parsed out to make a boolean `isContainsFilter` which is kept in each value of `QueryRefs.filterTuples` (previously `filterPairs`). Then when converting back in `convertQueryFromRefs` we construct `Query.contains: {[colId: string]: boolean}`. Finally `getFilterFunc` uses `Query.contains` to decide what kind of filtering to do. This is not pretty, but the existing code is already very complex and it was hard to find something that wouldn't require touching loads of code just to make things compile. Test Plan: Added a new nbrowser test and fixture, tests that selecting a source table by summary tables grouped by a choicelist column, non-list column, and both all filter the correct data. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2940	3 years ago
George Gevoian	9592e3610b	(core) Add 'value' to trigger formula autocomplete Summary: API signature for autocomplete updated to add column ID, which is necessary for exposing correct types for 'value'. Test Plan: Unit tests. Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: jarek, alexmojaki Differential Revision: https://phab.getgrist.com/D2896	3 years ago
Alex Hall	ea01ca814d	(core) Remove a bunch of dead code Summary: Removed test/aws/, most of app/server/lib/, 3 dirs in app/lambda/, corresponding tests, and more! Test Plan: a lot of this is quite the opposite... Reviewers: dsagal, paulfitz Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2894	3 years ago
Paul Fitzpatrick	6f02987d10	(core) allow undos to be partial, if access control prohibits some part of them Summary: This is a somewhat experimental change, that will implement permitted parts of an undo if not all parts are permitted. This is in preparation for trigger columns, where it may become common for a change in a record resulting in a change to an automatic change to another that the user cannot edit directly. How to undo such an action is somewhat unclear. One option is to undo the permitted parts, and then the triggers can rerun. The general case is a bit of a can of worms, and feels adjacent to merging/rebasing etc. Oh: it would probably be important in general to communicate to the user that an undo was partial, but this diff doesn't do that. It would need some new plumbing. Test Plan: added test Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2839	3 years ago
Paul Fitzpatrick	a1a84d99c0	(core) alert user if they try to use rec in a column rule controlling read permission Summary: This particular combination of features is not built out - data will be censored but changes to data will not. So the user will now get an error if they try to do it. Existing rules of this kind will continue to operate as before, and can be set via the api. Test Plan: added test Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2751	4 years ago
Dmitry S	d8e742aa0d	(core) Add getAclResources method for making all tables/columns available when editing ACL rules Summary: The goal is that those who can edit ACL rules can create or change rules for any resource, even if the rules block their own ability to see the resource. Test Plan: Added a browser test, and a server test for who can call the new method. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2703	4 years ago
Dmitry S	de35be6b0a	(core) Checks that an ACL formula can be parsed, and prevent saving unparsable ACL rules. Summary: - Fix error-handling in bundleActions(), and wait for the full bundle to complete. (The omissions here were making it impossibly to react to errors from inside bundleActions()) - Catch problematic rules early enough to undo them, by trying out ruleCollection.update() on updated rules before the updates are applied. - Added checkAclFormula() call to DocComm that checks parsing and compiling formula, and reports errors. - In UI, prevent saving if any aclFormulas are invalid, or while waiting for the to get checked. - Also fixed some lint errors Test Plan: Added a test case of error reporting in ACL formulas. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2689	4 years ago
Dmitry S	2399baaca2	(core) When saving copies, allow saving to another org; update menus for making and saving copies. Summary: - Implemented selecting an org in some cases when using Save-Copy dialog. - Unified previous 'Save Copy' menu into an enhanced "Share" menu. - Renamed ExportMenu to ShareMenu, collect related code into it, and design the share button. - Introduced trunkAccess property for forks, to know whether "Replace Original" is available. - Simplified handling of fork() result, now that all code has been upgraded. - Replaced 'Copy as Template' menu items with a checkbox in the Save-Copy dialog - Removed copy links for examples in the DocMenu (to simplify, since not part of updated design) - Updated the UI of the copying dialog. Test Plan: Updated affected tests, added new test cases for copying when other orgs are a choice or not. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2561	4 years ago
Paul Fitzpatrick	5ef889addd	(core) move home server into core Summary: This moves enough server material into core to run a home server. The data engine is not yet incorporated (though in manual testing it works when ported). Test Plan: existing tests pass Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2552	4 years ago

9 Commits (7e78ebfeebb592db4c49a00993dc4862ee09a499)