Commit Graph

4 Commits

Author SHA1 Message Date
Janet Vorobyeva
7b193c62a6 Address reviewer comments 2023-09-25 15:19:39 -07:00
Janet Vorobyeva
fa18307c9a Fixed test: RightPanelSelectBy disallow cycles
We now want to disallow most cycles, but allow same-table
cursor-linked cycles

Note: I tested that filtered cycles are forbidden,
same-table-cursor cycles are allowed,

but I never checked if different-table cursor cycles are forbidden
might be something to add, but would require more fiddling
2023-09-25 15:19:39 -07:00
Paul Fitzpatrick
230e84f48a
avoid test files importing other test files (#550)
There's a little nest of SelectBy tests that sometimes fail.
They are the only tests with an import of a helper function from
an other file that contains tests. Such imports have caused trouble
with mocha in the past. I'm not sure if that is the case now, but
I'd like to eliminate it as a possibility.
2023-06-29 03:15:14 -04:00
Jarosław Sadziński
e93dd4bc6f (core) Preserving cursor position when linked state is removed.
Summary:
- Preserving cursor position when linked state is removed.
- Moving linking tests to grist core.
- Disabling yarn offline mirror for grist-core. This helps testing grist-core when it is imported as a submodule.
- Moving one test for linked section from ReferenceColumns.ts to RightPanelSelectBy.ts.

Test Plan: Updated

Reviewers: paulfitz

Reviewed By: paulfitz

Subscribers: paulfitz

Differential Revision: https://phab.getgrist.com/D3795
2023-02-08 21:54:55 +01:00