9 Commits (6dd2068218e66180ac3df1fdd7b78f66be0801cf)

Author	SHA1	Message	Date
Jarosław Sadziński	b6f5718ad0	(core) Fixing ACIndex highlightMatches functions ... Summary: Highlighting wasn't working correctly for the new normalized search for autocomplate widgets. Test Plan: Existing tests Reviewers: alexmojaki Reviewed By: alexmojaki Differential Revision: https://phab.getgrist.com/D3602	2 years ago
Ronan Amicel	cd16650e0e	Rename text cleaning function to "normalizeText"	2 years ago
Ronan Amicel	4003d2d7c6	Use lodash to remove accents and ther diacritics ... https://lodash.com/docs/4.17.15#deburr	2 years ago
Ronan Amicel	2a05d04e35	Ignore diacritics in autocomplete ... Works for: - Choice - Choice List - Reference - Reference List Co-Authored-By: Louis Delbosc <louis.delbosc.prestataire@anct.gouv.fr>	2 years ago
Dmitry S	43a62e7254	(core) Fix autocomplete selection when options include emoji ... Summary: Searching for matching choices was using nativeCompare for a binary search, while the list was sorted according to localeCompare. This was causing the search to fail for some strings when the two orderings differ. Test Plan: Tested manually Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3059	3 years ago
Dmitry S	8d68c1c567	(core) Replace time zone selector with one based on the newer autocomplete. ... Summary: Flaky Dates test failures related to the use of JQuery autocomplete for time zones, which wasn't working well. This diff replaces that autocomplete (as well as a similar select box in DocumentSettings) with our newer autocomplete, adding some select-box like behavior. Most of the behavior is factored out into ACSelect, which could be more generally useful. Adds an option to autocomplete to keep options ordered according to their initial order. Unrelated: fix up usage of MultiHolder in Drafts to avoid 'already disposed' warnings. Test Plan: Fixed several affected tests. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D2919	3 years ago
George Gevoian	5b2666a88a	(core) Enhance autocomplete and choice colors ... Summary: Choice columns can now add new choices directly from the autocomplete menu. The autocomplete will now highlight the first matching item, even if there are equally ranked alternatives. No changes have been made to how the autocomplete index is created, or how it scores items. For choice and choice list columns, the filter menu will now display values using their configured colors, similar to the rest of the UI. Choice tokens throughout the UI now do a better job of handling text overflow by showing an ellipsis whenever there isn't enough space to show the full text of a choice. Test Plan: Browser tests. Reviewers: cyprien Reviewed By: cyprien Differential Revision: https://phab.getgrist.com/D2904	3 years ago
Dmitry S	6e844a2e76	(core) Use unicode-aware comparisons for user-visible strings. ... Summary: - Switch code that compares user strings to use localeCompare() based on Intl.Collator. - Use en-US locale for now. (Ideally should be a document property.) - Note that with this change, sorting is also becoming case-insensitive (which seems an improvement) - Updated a sorted test fixture - Updated a browser test with lots of unicode to expect different order. - Added a bit of unicode to test ordering in Reference autocomplete dropdown. Test Plan: Fixed / updated tests Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2758	3 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core ... Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago