2 Commits (643dacafbfcfb195783a92b387004c9ddb6da5d2)

Author	SHA1	Message	Date
Paul Fitzpatrick	2a206dfcf8	(core) add initial support for special shares ... Summary: This gives a mechanism for controlling access control within a document that is distinct from (though implemented with the same machinery as) granular access rules. It was hard to find a good way to insert this that didn't dissolve in a soup of complications, so here's what I went with: * When reading rules, if there are shares, extra rules are added. * If there are shares, all rules are made conditional on a "ShareRef" user property. * "ShareRef" is null when a doc is accessed in normal way, and the row id of a share when accessed via a share. There's no UI for controlling shares (George is working on it for forms), but you can do it by editing a `_grist_Shares` table in a document. Suppose you make a fresh document with a single page/table/widget, then to create an empty share you can do: ``` gristDocPageModel.gristDoc.get().docData.sendAction(['AddRecord', '_grist_Shares', null, {linkId: 'xyz', options: '{"publish": true}'}]) ``` If you look at the home db now there should be something in the `shares` table: ``` $ sqlite3 -table landing.db "select * from shares" +----+------------------------+------------------------+--------------+---------+ | id | key | doc_id | link_id | options | +----+------------------------+------------------------+--------------+---------+ | 1 | gSL4g38PsyautLHnjmXh2K | 4qYuace1xP2CTcPunFdtan | xyz | ... | +----+------------------------+------------------------+--------------+---------+ ``` If you take the key from that (gSL4g38PsyautLHnjmXh2K in this case) and replace the document's urlId in its URL with `s.<key>` (in this case `s.gSL4g38PsyautLHnjmXh2K` then you can use the regular document landing page (it will be quite blank initially) or API endpoint via the share. E.g. for me `http://localhost:8080/o/docs/s0gSL4g38PsyautLHnjmXh2K/share-inter-3` accesses the doc. To actually share some material - useful commands: ``` gristDocPageModel.gristDoc.get().docData.getMetaTable('_grist_Views_section').getRecords() gristDocPageModel.gristDoc.get().docData.sendAction(['UpdateRecord', '_grist_Views_section', 1, {shareOptions: '{"publish": true, "form": true}'}]) gristDocPageModel.gristDoc.get().docData.getMetaTable('_grist_Pages').getRecords() gristDocPageModel.gristDoc.get().docData.sendAction(['UpdateRecord', '_grist_Pages', 1, {shareRef: 1}]) ``` For a share to be effective, at least one page needs to have its shareRef set to the rowId of the share, and at least one widget on one of those pages needs to have its shareOptions set to {"publish": "true", "form": "true"} (meaning turn on sharing, and include form sharing), and the share itself needs {"publish": true} on its options. I think special shares are kind of incompatible with public sharing, since by their nature (allowing access to all endpoints) they easily expose the docId, and changing that would be hard. Test Plan: tests added Reviewers: dsagal, georgegevoian Reviewed By: dsagal, georgegevoian Subscribers: jarek, dsagal Differential Revision: https://phab.getgrist.com/D4144	9 months ago
Jarosław Sadziński	64710b60f3	(core) Moving nbrowser tests to grist-core ... Summary: Moving bulk of nbrowser tests to core. Some tests were split and only part of them were moved. Tests that are left are either: not suitable for grist-core (like billing) or are failing during browser tests (are not reliable). Four fixtures directory (uploads, docs, exports-csv/excel) where completely moved to grist-core and are linked as folders. Those changes allows to add an nbrowser test in grist-core or in the main test folder without any need to link it or link a fixture document. Other changes: - testrun.sh has been modified, now it runs tests from both folders (test and core/test), - TestServer used in grist-core is now adding sample orgs and users (kiwi and others), Test modified - SelectionSummary: now it is run on a bigScreen, it was failing randomly - Billing.ts: relative paths were used - DateEditor: added waitForServer - it was failing in browser mode - FrozenColumns, ImportFromGDrive, Printing: updated import paths - UserManager.ts: was split into two parts (it assumed limited products) - ViewLayoutResize.ts: this test is still in main repo, it is still failing in browser mode tests Test Plan: Existing Reviewers: paulfitz Reviewed By: paulfitz Subscribers: dsagal, paulfitz Differential Revision: https://phab.getgrist.com/D3664	2 years ago