gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Alex Hall	80bf4ea2a3	(core) Get first unicode character (e.g. 📝 ) for page label, not 1st byte Summary: 📝 https://community.getgrist.com/t/feature-request-custom-icon-favicon-for-each-document/210/2 ``` >>> json.dumps("📝") '"\\ud83d\\udcdd"' >>> json.dumps("✨") '"\\u2728"' ``` ``` > "📝 abc"[0] '\uD83D' > "📝 abc"[1] '\uDCDD' > Array.from("📝 abc") ['📝', ' ', 'a', 'b', 'c'] > Array.from("📝 abc")[0] '📝' ``` Test Plan: no Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3026	3 years ago
Dmitry S	70160fe01c	(core) Rename page option 'Duplicate' to 'Duplicate Page', and shorten warning to be more noticeable Test Plan: Changes too minor to affect tests Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3016	3 years ago
Alex Hall	73c4efa315	(core) Hide the GristDocTour table by default but reveal it when /p/GristDocTour is in the URL Summary: Adds 'GristDocTour' as a possible value of urlState().docPage GristDoc checks for this and converts it to a normal view record ID It also then sets a flag showGristDocTour=true which tells Pages.ts to show the page in the sidebar Otherwise the page is 'hidden' in the sidebar in the same way it would be if blocked by ACL rules This all feels very hacky, but I don't know this code well enough to know if there's a better way. Hopefully this behaviour is temporary. Test Plan: Tested manually, not sure if this is worth an automated test at this stage Reviewers: paulfitz, dsagal Reviewed By: paulfitz, dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D2953	3 years ago
Paul Fitzpatrick	4ab096d179	(core) granular access control in the presence of schema changes Summary: - Support schema changes in the presence of non-trivial ACL rules. - Fix update of `aclFormulaParsed` when updating formulas automatically after schema change. - Filter private metadata in broadcasts, not just fetches. Censorship method is unchanged, just refactored. - Allow only owners to change ACL rules. - Force reloads if rules are changed. - Track rule changes within bundle, for clarity during schema changes - tableId and colId changes create a muddle otherwise. - Show or forbid pages dynamically depending on user's access to its sections. Logic unchanged, just no longer requires reload. - Fix calculation of pre-existing rows touched by a bundle, in the presence of schema changes. - Gray out acl page for non-owners. Test Plan: added tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2734	4 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago

5 Commits (62db263d1fbfc783b2272af06b91ecc7d5870af6)