gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Alex Hall	6ac0bc3bbb	(core) Implement exported functions without relying on ActiveDoc.docData Summary: For grist-static, we want to the data engine to be able to call external/exported JS functions directly, rather than via the node 'server' living in another thread which requires synchronous communication hackery. As a step in that direction, this diff changes the exported functions that we care about (guessColInfo and convertFromColumn) to just using the top-level functions instead of relying on fields in ActiveDoc, namely docData. For guessColInfo, this is done by directly passing the small amount of metadata that was previously retrieved from the DocData. For convertFromColumn, disentangling DocData is a lot more complicated, so instead we construct a fresh DocData object using the required metadata tables which are now passed in by the data engine. Test Plan: Existing tests Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3913	1 year ago
Alex Hall	f877f3859d	(core) Use visible column formatting when converting RefList to Text Summary: Tweaked ReferenceListFormatter and ValueConverter to sensibly convert to Text. Fixes an embarrassing bug exposed during checkin 😱 Test Plan: Add test for converting from RefList displaying formatted dates to Text Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3254	3 years ago
Alex Hall	5d671bf0b3	(core) New type conversion in the backend Summary: This is https://phab.getgrist.com/D3205 plus some changes (https://github.com/dsagal/grist/compare/type-convert...type-convert-server?expand=1) that move the conversion process to the backend. A new user action ConvertFromColumn uses `call_external` so that the data engine can delegate back to ActiveDoc. Code for creating formatters and parsers is significantly refactored so that most of the logic is in `common` and can be used in different ways. Test Plan: The original diff adds plenty of tests. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3240	3 years ago

Author

SHA1

Message

Date

Alex Hall

6ac0bc3bbb

(core) Implement exported functions without relying on ActiveDoc.docData

Summary:
For grist-static, we want to the data engine to be able to call external/exported JS functions directly,
rather than via the node 'server' living in another thread which requires synchronous communication hackery.

As a step in that direction, this diff changes the exported functions that we care about (guessColInfo and convertFromColumn)
to just using the top-level functions instead of relying on fields in ActiveDoc, namely docData.

For guessColInfo, this is done by directly passing the small amount of metadata that was previously retrieved from the DocData.

For convertFromColumn, disentangling DocData is a lot more complicated, so instead we construct a fresh DocData object using
the required metadata tables which are now passed in by the data engine.

Test Plan: Existing tests

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D3913

Alex Hall

f877f3859d

(core) Use visible column formatting when converting RefList to Text

Summary: Tweaked ReferenceListFormatter and ValueConverter to sensibly convert to Text. Fixes an embarrassing bug exposed during checkin 😱

Test Plan: Add test for converting from RefList displaying formatted dates to Text

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D3254

Alex Hall

5d671bf0b3

(core) New type conversion in the backend

Summary: This is https://phab.getgrist.com/D3205 plus some changes (https://github.com/dsagal/grist/compare/type-convert...type-convert-server?expand=1) that move the conversion process to the backend. A new user action ConvertFromColumn uses `call_external` so that the data engine can delegate back to ActiveDoc. Code for creating formatters and parsers is significantly refactored so that most of the logic is in `common` and can be used in different ways.

Test Plan: The original diff adds plenty of tests.

Reviewers: georgegevoian

Reviewed By: georgegevoian

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D3240

3 Commits (53238b3e7b5882cfeccd21851bfc09ad1a3798cc)