gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Paul Fitzpatrick	d6abe6a737	(core) finish porting test/browser/.test.js tests Summary: This finishes porting the bulk of tests relying on the old selenium pseudo-promise manager. Here the remaining ones that I know of: There are some tests written in typescript at test/browser/.test.ts (I've olny been looking at the older .test.js ones so far) * There are some tests in test/home that run a slightly different way First version of this diff just had renames, so for reviewing it is likely easiest to switch to a comparison of that version with the final version. I switched from using test.(describe/it/...) to straight mocha since the indirection was confusing mocha-webdriver's debug functions (e.g. it was misnaming screenshots). That resulted in a lot of noise in the diff, sorry! Some tests fail in headless operation in modern chrome for what looks to be the same reason as https://github.com/gristlabs/grist-core/pull/490 (some copy/paste nuance or change). Test Plan: test porting Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3862	1 year ago
George Gevoian	3aac027a13	(core) Polish tutorial popups Summary: Includes the following changes: * Adds "Click to expand" hover tooltip to all images * Adds support for minimize/maximize by double clicking tutorial popup header * Add New menu (and all other popups) should now persist when user moves tutorial popup * Preserves scrollbar position when minimizing and maximizing tutorial popup * Formula cell editor (and other elements) should now be stacked under tutorial Test Plan: Browser and manual tests. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3864	1 year ago
Jarosław Sadziński	35f7072bea	(core) Enabling height adjustment on tutorial popup Summary: Support height adjustment for tutorial popup, also change the way we calculate delta for the movement to make it follow the cursor more smoothly. Test Plan: Added Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: JakubSerafin Differential Revision: https://phab.getgrist.com/D3858	1 year ago
George Gevoian	b15ae98349	(core) Fix browser history bug with tutorials Summary: History wasn't being replaced in some cases, which was causing a bug where trying to leave a tutorial fork via the browser's back button would navigate back to the trunk, and trigger forking again. This effectively made it impossible to leave a tutorial. Also adds support for specifying custom CSS classes for tutorial Markdown images. Test Plan: Browser test. Reviewers: JakubSerafin Reviewed By: JakubSerafin Differential Revision: https://phab.getgrist.com/D3866	1 year ago
George Gevoian	4ce7e21bab	(core) Fix flaky DocTutorial test Summary: The substring for the anchor link row id was missing a leading ".", which was a problem because tutorial fork ids would sometimes contain the substring. Test Plan: N/A Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3853	1 year ago
George Gevoian	0006e0604b	(core) Disable tips during tutorials Summary: Behavioral tips shouldn't be shown during tutorials. Test Plan: Browser test. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3842	2 years ago
George Gevoian	5b2fb62627	(core) Avoid clashes with rick rowing and tours Summary: In certain scenarios, it's possible for a Grist tour and a tip that kicks off an easter egg to be shown on screen at the same time. To deconflict, we now check for the presence of one or the other and avoid showing both. Test Plan: Browser tests. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3840	2 years ago
Jarosław Sadziński	a317a727c8	(core) Adding tutorial card Summary: For now only html stub and docList adjustement for showing a tutorial card. It will be used in future diffs after tutorial implementation. Test Plan: Manual Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3750	2 years ago
Jarosław Sadziński	d29770511c	(core) Draft version of AI assistant Summary: The feature is behind a flag GRIST_FORMULA_ASSISTANT (must be "true"). But can be enabled in the developer console by invoking GRIST_FORMULA_ASSISTANT.set(true). Keys can be overriden in the document settings page. Test Plan: For now just a stub test that checks if this feature is disabled by default. Reviewers: paulfitz Reviewed By: paulfitz Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3815	2 years ago
George Gevoian	be8e13df64	(core) Add initial tutorials implementation Summary: Documents can now be flagged as tutorials, which causes them to display Markdown-formatted slides from a special GristDocTutorial table. Tutorial documents are forked on open, and remember the last slide a user was on. They can be restarted too, which prepares a new fork of the tutorial. Test Plan: Browser tests. Reviewers: jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D3813	2 years ago

10 Commits (4bdbba03e822685638a3b4b89de4020a021ae9fb)