gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
George Gevoian	24fc3a2d00	(core) Redesign examples and templates UI Summary: The old Examples and Templates workspace is now a page that pulls templates from a new public Grist Templates org. The All Documents view will pull featured templates from that org, where featured templates are simply pinned documents in Grist Templates. The Examples and Templates page will also show the featured templates, as well as the rest of the available templates organized by category. The categories are equivalent to workspaces in Grist Templates, and are generated dynamically. Test Plan: Browser tests. Reviewers: paulfitz, dsagal Reviewed By: paulfitz, dsagal Subscribers: dsagal, paulfitz, jarek Differential Revision: https://phab.getgrist.com/D2930	3 years ago
Alex Hall	cd0c6de53e	(core) Automatically or explicitly show document tours in the same way as example cards. Summary: Extracts code from showExampleCard into a generic function which is reused for document tours. It handles reading and writing to user preferences for automatic showing and explicitly reopening. Test Plan: Manually tested that it automatically shows a tour just once and clicking to reopen works. There's not much new functionality so there's little that needs testing. This is an initial version that's mostly internal and is likely to be polished for users in the future. If I should still add tests, I'd like confirmation that the current behaviour is as desired. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2944	3 years ago
Alex Hall	1f6e693b6e	(core) Remove REPL code Summary: Remove repl.py, REPLTab.js, some wiring code, CSS, and a test in testscript.json. Test Plan: NA Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2923	3 years ago
Dmitry S	8c2bea0f73	(core) Remove the aclUI=1 flag and add 'BETA' tag to the Access Rules page name. Summary: - Remove support for aclUI=1 URL parameter, making it the default. - Add 'BETA' tag to the Access Rules link in side panel. - Remove all mentions of aclUI=1 in tests. Test Plan: Updated tests should pass Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2766	4 years ago
Paul Fitzpatrick	9d1bc5a518	(core) make AccessRules and FullCopies effective Summary: This allows `SPECIAL:AccessRules` to give read access to the access rules to more users, and `SPECIAL:FullCopies` to grant download/copy rights to more users. This diff also changes forks to be owned by the user who forked them (previously they were an editor), since that feels more natural. Test Plan: Added and updated tests. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2760	4 years ago
Dmitry S	3f29baaded	(core) Add a button and a tooltip to Access Rules page item, in View-As mode. Summary: - When in View-As mode, clicking the Access Rules page now shows a tooltip with a link to return to normal mode and open the Access Rules page. - A "revert" button is shown next to the item with the same behavior. - Implemented hoverTooltip() with various options. (It will have other uses.) - Simplify creation of links based on UrlState: - Allow merging with previous urlState using a function - Add a helper function to merge in aclAsUser parameter. - Add setHref() method to UrlState Test Plan: Added test cases: - for tooltips generally in test/projects - for updating UrlState using a callback - for Access Rules tooltip and button behavior Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2749	4 years ago
Paul Fitzpatrick	c37a04c578	(core) freshen "view as user" behavior Summary: Now as the user an owner might choose to view their document as is likely to not have access to rules, it is better to start viewing on the default document page rather than /p/acl. The "Access Rules" link is grayed out when in "view as" mode for now (improvements are planned). Test Plan: updated test Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2743	4 years ago
Paul Fitzpatrick	4ab096d179	(core) granular access control in the presence of schema changes Summary: - Support schema changes in the presence of non-trivial ACL rules. - Fix update of `aclFormulaParsed` when updating formulas automatically after schema change. - Filter private metadata in broadcasts, not just fetches. Censorship method is unchanged, just refactored. - Allow only owners to change ACL rules. - Force reloads if rules are changed. - Track rule changes within bundle, for clarity during schema changes - tableId and colId changes create a muddle otherwise. - Show or forbid pages dynamically depending on user's access to its sections. Logic unchanged, just no longer requires reload. - Fix calculation of pre-existing rows touched by a bundle, in the presence of schema changes. - Gray out acl page for non-owners. Test Plan: added tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2734	4 years ago
Dmitry S	8c788005c3	(core) Implement much of the general AccessRules UI. Summary: - Factored out ACLRuleCollection into its own file, and use for building UI. - Moved AccessRules out of UserManager to a page linked from left panel. - Changed default RulePart to be the last part of a rule for simpler code. - Implemented much of the UI for adding/deleting rules. - For now, editing the ACLFormula and Permissions is done using text inputs. - Implemented saving rules by syncing a bundle of them. - Fixed DocData to clean up action bundle in case of an early error. Test Plan: WIP planning to add some new browser tests for the UI Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2678	4 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago

10 Commits (4a23b964ed8f74379a8dae5323a98f75ab883026)