gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
George Gevoian	5b2666a88a	(core) Enhance autocomplete and choice colors Summary: Choice columns can now add new choices directly from the autocomplete menu. The autocomplete will now highlight the first matching item, even if there are equally ranked alternatives. No changes have been made to how the autocomplete index is created, or how it scores items. For choice and choice list columns, the filter menu will now display values using their configured colors, similar to the rest of the UI. Choice tokens throughout the UI now do a better job of handling text overflow by showing an ellipsis whenever there isn't enough space to show the full text of a choice. Test Plan: Browser tests. Reviewers: cyprien Reviewed By: cyprien Differential Revision: https://phab.getgrist.com/D2904	3 years ago
Cyprien P	7a0cd6c2b4	(core) Makes filter counts take other column filters into account Summary: Makes filter counts take other column filters into account. - Changes the summaries rows to reflect hidden rows: - hidden rows are added to the `Other Values` summary - show the unique number of other values as `Other Values (12)` - Also, adds a sort button to the column filter menu Test Plan: Adds browser test. Reviewers: paulfitz, jarek Reviewed By: jarek Differential Revision: https://phab.getgrist.com/D2861	3 years ago
Cyprien P	b740028e8f	(core) Increases readability of column filter menu code Summary: The `select-all` originally designed the `All` button but it unfortunately evolves into designating both `All` and `None`. Which is confusing. Replaces with the more general `bulk-action`. Test Plan: Should not break anything. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2860	3 years ago
George Gevoian	b94eb107d4	(core) Use individual choices for filtering choice lists Test Plan: Wrote unit and browser tests that verify new behavior. Reviewers: paulfitz, dsagal Reviewed By: dsagal Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D2855	3 years ago
Jarosław Sadziński	96fee73b70	(core) Download as CSV button on sections Summary: Adding "Download as CSV" button that exports filtred section data to csv Test Plan: Browser tests Reviewers: paulfitz, dsagal Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2830	3 years ago
Cyprien P	8056bb0069	(core) close sort&filter menu when clicking Save/Revert buttons Summary: - close sort&filter menu when clicking Save/Revert buttons - also closes when clicking Apply/Cancel from a nested filter menu Test Plan: - updated existing test to match new spec - added new test to cover new behaviour Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2799	3 years ago
Cyprien P	5479159960	(core) add `+` button to the filter bar Summary: - Adds a + button to the filter. Button triggers a menu that allow to add one of the column that does not already have a filter set. Caveats: - for now menu only allows to choose from visible column. - This diff introduces a slight change of behavior of how filter works: - Filter used to be automatically removed when user set them to all inclusive (ie: by clicking the `All` button). - With this diff, it is no longer the case. - indeed, when filter are added to the filter bar with the `+` btn they are initially in the `all inclusive` state, hence would have been removed with the above mention behaviour. Test Plan: Added new test to nbrowser/FilterBar Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2776	3 years ago
Cyprien P	8a26550312	(core) Fix issue when using `Other Values` with many rows Summary: Fix an error that used to happen on Chrome: `RangeError: Maximum call stack size exceeded`. Happened when clicking the `Other Values` checkbox when filtering a large table. Turns out culprit was a function call that was using a spread operator to pass a large number of argument to a function. Spread operator for passing multiple argument must not be used with too many arguments. Otherwise it could hit the engine's argument length limit. That limit varies across browser (webkit's javascriptcore engine has argument limit of 65536). Some interesting description of the limit can be found here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Function/apply#using_apply_and_built-in_functions In order to get the fix fast, implementing a proper test for it is left for a follow-up commit. Test Plan: - Manually tested on Chrome/FF Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D2779	3 years ago
Cyprien P	2b1b586ecd	(core) add new filter bar Summary: - add new filterBar option to views section - add toggle to the section menu - add filter bar - shows Save/Revert btn when unsaved change - shows all filered fields witch edit and delete buttons Test Plan: Add new FilterBar nbrowser test Reviewers: paulfitz, dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2769	3 years ago
Cyprien P	351a717e6d	(core) Adds `limitShown` option to ColumnFilterMenu, defaults to 500 Summary: - Allows ColumnFilter to add/delete keys by batch - Add options limitShown to ColumnFilterMenu - Add summary checkboxes Other Matching/Other Non-Matching/Other Values - Adds missing type to chai declaration Test Plan: - Adds project test to new file projects/ColumnFilterMenu2 - Adds nbrowser test to new file nbrowser/ColumnFilterMenu Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2763	4 years ago
Cyprien P	34f8078ead	(core) Fix searching in filter for coltype not a text-or-number (ie: Date) Summary: - Simply apply search against word label instead of the key - Fix a tricky bug of observable dependencies that appeared while working on this diff. Test Plan: Added a browser test for searching date in the filter menu. Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D2762	4 years ago
Cyprien P	e2d3b70509	(core) Filtering improvement - part 1 Summary: - Makes search input alway visible - Gives search input focus on open - Adds `Future Values` Checkbox - Show `All Shown` `All Excpet` when values are filtered - Show `Others` instead of `Future Values` when values are filtered - Escape close search input - Enter does the same as `All Shown` when filtering values Test Plan: - Updated existing projects and nbrowser test - Adds new projects test Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2753	4 years ago
Dmitry S	6e844a2e76	(core) Use unicode-aware comparisons for user-visible strings. Summary: - Switch code that compares user strings to use localeCompare() based on Intl.Collator. - Use en-US locale for now. (Ideally should be a document property.) - Note that with this change, sorting is also becoming case-insensitive (which seems an improvement) - Updated a sorted test fixture - Updated a browser test with lots of unicode to expect different order. - Added a bit of unicode to test ordering in Reference autocomplete dropdown. Test Plan: Fixed / updated tests Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2758	4 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago

14 Commits (4a23b964ed8f74379a8dae5323a98f75ab883026)