gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Alex Hall	3445ecb64c	(core) Search backwards with Shift+Enter Summary: As simple as it sounds. Check ev.shiftKey in Enter key handler in search.ts. Test Plan: Extended test/nbrowser/Search.ts Reviewers: jarek Reviewed By: jarek Subscribers: jarek Differential Revision: https://phab.getgrist.com/D3293	3 years ago
Jarosław Sadziński	745ddc21ac	(core) Expanding search textbox to full height. Summary: Expanding search input field to full available height, to make the clickable area bigger. Test Plan: Manual tests on browserstack Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3145	3 years ago
Dmitry S	f0da3eb3b2	(core) Select previous search input when clicking the search icon Summary: Searching with the keyboard shortcut selected the previous search text in the search box, but using the Search icon did not. A user reported it as an inconvenience: having to manually delete the value before searching for a new one. Test Plan: Verified manually Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: georgegevoian Differential Revision: https://phab.getgrist.com/D3102	3 years ago
Cyprien P	8c6148dd9f	(core) fix closing of the search bar Summary: - Sending `ESCAPE` while hovering the options panel was not working - This is because of the keepExpanded flag which was set to true - Solution is to set the keepExpanded flag to false, prior to toggling the Menu Test Plan: - Tested manually Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2836	3 years ago
Dmitry S	d1c1416d78	(core) Add rules to eslint to better match our coding conventions. Summary: We used tslint earlier, and on switching to eslint, some rules were not transfered. This moves more rules over, for consistent conventions or helpful warnings. - Name private members with a leading underscore. - Prefer interface over a type alias. - Use consistent spacing around ':' in type annotations. - Use consistent spacing around braces of code blocks. - Use semicolons consistently at the ends of statements. - Use braces around even one-liner blocks, like conditionals and loops. - Warn about shadowed variables. Test Plan: Fixed all new warnings. Should be no behavior changes in code. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2831	3 years ago
Cyprien P	db91d31416	(core) Search improvemement Summary: This diff implements the search improvement that are mentioned here https://grist.quip.com/j1biAmfGkbzV/Search-Improvements. CAVEATS: I've noticed a bit of a usability caveats: the tooltips overlap with the new `search all pages` checkbox, which requires user to move cursor away for a bit in order to be able to click the button. {F28224} I've experimented locally with tooltips showing on both sides of the arrows, but it overlaps with the cross icon so could also be an issue. I couldn't think of any clear simple alternative, probably not too big of an issue anyway. Test Plan: Added new test. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2818	3 years ago
Dmitry S	aae4a58300	(core) A few improvements to CSS on mobile. Summary: - Adjust ExampleCard css to fit on x-small screens, including its close button, so that it may be closed. - In TopBar on small screens, hide Notifications button and default action for Share; adjust spacing. - Add overflow: hidden to PagePanels, to make sure it doesn't slide off of visible area. Test Plan: Tested on iOS. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2741	4 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago

8 Commits (321019217d6af6396324bb11999504890a7a8dd2)