2 Commits (2705d41c34f017ef746bbe6b90cbbecffe659f14)

Author	SHA1	Message	Date
Dmitry S	2705d41c34	(core) Add timeouts to prevent ActiveDoc bad state during shutdown. ... Summary: Add two shutdown-related timeouts. 1. One is to limit the duration of any work that happens once shutdown begins. In particular, waiting for an update to current time could block indefinitely if the data engine is unresponsive. Such awaits are now limited to 5 seconds. 2. The other is to allow documents to get shutdown for inactivity even when some work takes forever. Certain work (e.g. applying user actions) generally prevents a document from shutting down while it's pending. This prevention is now limited to 5 minutes. Shutting down a doc while something is pending may break some assumptions, and lead to errors. The timeout is long to let us assume that the work is stuck, and that errors are better than waiting forever. Other changes: - Periodic ActiveDoc work (intervals) is now started when a doc finishes loading rather than in the constructor. The difference only showed up in tests which makes the intervals much shorter. - Move timeoutReached() utility function to gutil, and use it for isLongerThan(), since they are basically identical. Also makes sure that the timer in these is cleared in all cases. - Remove duplicate waitForIt implementation (previously had a copy in both test/server and core/test/server). - Change testUtil.captureLog to pass messages to its callback, to allow asserts on messages within the callback. Test Plan: Added new unittests for the new shutdowns, including a replication of a bad state that was possible during shutdown. Reviewers: paulfitz Reviewed By: paulfitz Subscribers: paulfitz Differential Revision: https://phab.getgrist.com/D4040	9 months ago
Jarosław Sadziński	64710b60f3	(core) Moving nbrowser tests to grist-core ... Summary: Moving bulk of nbrowser tests to core. Some tests were split and only part of them were moved. Tests that are left are either: not suitable for grist-core (like billing) or are failing during browser tests (are not reliable). Four fixtures directory (uploads, docs, exports-csv/excel) where completely moved to grist-core and are linked as folders. Those changes allows to add an nbrowser test in grist-core or in the main test folder without any need to link it or link a fixture document. Other changes: - testrun.sh has been modified, now it runs tests from both folders (test and core/test), - TestServer used in grist-core is now adding sample orgs and users (kiwi and others), Test modified - SelectionSummary: now it is run on a bigScreen, it was failing randomly - Billing.ts: relative paths were used - DateEditor: added waitForServer - it was failing in browser mode - FrozenColumns, ImportFromGDrive, Printing: updated import paths - UserManager.ts: was split into two parts (it assumed limited products) - ViewLayoutResize.ts: this test is still in main repo, it is still failing in browser mode tests Test Plan: Existing Reviewers: paulfitz Reviewed By: paulfitz Subscribers: dsagal, paulfitz Differential Revision: https://phab.getgrist.com/D3664	2 years ago