4 Commits

Author	SHA1	Message	Date
Jakub Serafin	f7fdfab6bf	(core) GET endpoint for webhooks returns now data in format {webhooks:[...]} ... Summary: Rework of endpoint GET for webhooks to make it coherent with other endpoints. Now data should be return in {webhooks:[{id:"...",fields:{"..."}]} format ``` { "webhooks": [ { "id": ... "fields": { "url": ... "unsubscribeKey": ... "eventTypes": [ "add", "update" ], "isReadyColumn": null, "tableId": "...", "enabled": false, "name": "...", "memo": "..." }, "usage": { "status": "idle", "numWaiting": 0, "lastEventBatch": null } }, { "id": "...", "fields": { "url": "...", "unsubscribeKey": "...", "eventTypes": [ "add", "update" ], "isReadyColumn": null, "tableId": "...", "enabled": true, "name": "...", "memo": "..." }, "usage": { "status": "error", "numWaiting": 0, "updatedTime": 1689076978098, "lastEventBatch": { "status": "rejected", "httpStatus": 404, "errorMessage": "{\"success\":false,\"error\":{\"message\":\"Alias 5a9bf6a8-4865-403a-bec6-b4ko not found\",\"id\":null}}", "size": 49, "attempts": 5 }, "lastSuccessTime": null, "lastFailureTime": 1689076978097, "lastErrorMessage": "{\"success\":false,\"error\":{\"message\":\"Alias 5a9bf6a8-4865-403a-bec6-b4ko not found\",\"id\":null}}", "lastHttpStatus": 404 } } ] } ``` Test Plan: new test added to check if GET data fromat is correct. Other tests fixed to handle changed endpoint. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D3966	2023-07-26 11:36:24 +02:00
Paul Fitzpatrick	8ecf0d7d0a	change order of new private method to fix lint after saas/core sync (#587)	2023-07-23 14:51:19 -04:00
Jakub Serafin	d894b60fd4	(core) deleting queue from single webhook ... Summary: Using standard tost notification, message about webhook queue being overflown was added. message is permanent as long as queue is full. Message contains linkt to the webhook setings Test Plan: two nbrowser test was added - one to check if message is show when queue is full, and second to check if message is dismiss when queue was cleaned. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: jarek Differential Revision: https://phab.getgrist.com/D3929	2023-07-18 11:46:10 +02:00
Paul Fitzpatrick	603238e966	(core) Adds a UI panel for managing webhooks ... Summary: This adds a UI panel for managing webhooks. Work started by Cyprien Pindat. You can find the UI on a document's settings page. Main changes relative to Cyprien's demo: * Changed behavior of virtual table to be more consistent with the rest of Grist, by factoring out part of the implementation of on-demand tables. * Cell values that would create an error can now be denied and reverted (as for the rest of Grist). * Changes made by other users are integrated in a sane way. * Basic undo/redo support is added using the regular undo/redo stack. * The table list in the drop-down is now updated if schema changes. * Added a notification from back-end when webhook status is updated so constant polling isn't needed to support multi-user operation. * Factored out webhook specific logic from general virtual table support. * Made a bunch of fixes to various broken behavior. * Added tests. The code remains somewhat unpolished, and behavior in the presence of errors is imperfect in general but may be adequate for this case. I assume that we'll soon be lifting the restriction on the set of domains that are supported for webhooks - otherwise we'd want to provide some friendly way to discover that list of supported domains rather than just throwing an error. I don't actually know a lot about how the front-end works - it looks like tables/columns/fields/sections can be safely added if they have string ids that won't collide with bone fide numeric ids from the back end. Sneaky. Contains a migration, so needs an extra reviewer for that. Test Plan: added tests Reviewers: jarek, dsagal Reviewed By: jarek, dsagal Differential Revision: https://phab.getgrist.com/D3856	2023-05-08 18:25:27 -04:00