gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Jarosław Sadziński	995bf9b63a	(core) Distinct style rules for summary columns Summary: Summary columns now have their own conditional rules, which are not shared with sister columns. Test Plan: New test Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3388	2 years ago
Cyprien P	0829ae67ef	(core) Fixing hidden col missing after summary update Summary: Updating one summary groupby columns is handle by the `update_summary_section`. That routine is in charge of creating a new summary table and transfer all possible columns from old table to the new one, so that the new table appear to change only the minimum to users. The problem that this diff address is that, the logic to decide what columns we need to keep, only applies to the visible fields and ignore the hidden columns, causing all hidden columns to be removed. This diff, simply changes that routine to address all columns. the mutliple fixes on the test_summary2.py result from a change of ordering of columns: the culprit is the `group` columns, which is by default a hidden columns and that had to be explicitely added back to the new summary table. It is now transferred automatically, like other columns, which does cause a little change of ordering on the db. This should not result in any display order changes for the users. Recent related diff: https://phab.getgrist.com/D3351 Test Plan: Includes new test case; both python and nbrowser Reviewers: alexmojaki Reviewed By: alexmojaki Differential Revision: https://phab.getgrist.com/D3393	2 years ago
Cyprien P	a6ba40558a	(core) Fix missing sum column after a summary table update Summary: Description of the problem can be found here: https://grist.slack.com/archives/C069RUP71/p1634899282005600 - users removing a group by column that is of type numeric was resulting in the column missing from the summary table. Where instead is should be present as a 'SUM($group.${col.colId})' formula column - this diff fixes that issue and adds unit test Test Plan: Should not break anything. Adds not test case. Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D3351	2 years ago
Jarosław Sadziński	b1c3943bf4	(core) Conditional formatting rules Summary: Adding conditional formatting rules feature. Each column can have multiple styling rules which are applied in order when evaluated to a truthy value. - The creator panel has a new section: Cell Style - New user action AddEmptyRule for adding an empty rule - New columns in _grist_Table_columns and fields A new color picker will be introduced in a follow-up diff (as it is also used in choice/choice list/filters). Design document: https://grist.quip.com/FVzfAgoO5xOF/Conditional-Formatting-Implementation-Design Test Plan: new tests Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: alexmojaki Differential Revision: https://phab.getgrist.com/D3282	3 years ago
Jarosław Sadziński	3c72639e25	(core) Adding sort options for columns. Summary: Adding sort options for columns. - Sort menu has a new option "More sort options" that opens up Sort left menu - Each sort entry has an additional menu with 3 options -- Order by choice index (for the Choice column, orders by choice position) -- Empty last (puts empty values last in ascending order, first in descending order) -- Natural sort (for Text column, compares strings with numbers as numbers) Updated also CSV/Excel export and api sorting. Most of the changes in this diff is a sort expression refactoring. Pulling out all the methods that works on sortExpression array into a single namespace. Test Plan: Browser tests Reviewers: alexmojaki Reviewed By: alexmojaki Subscribers: dsagal, alexmojaki Differential Revision: https://phab.getgrist.com/D3077	3 years ago
Alex Hall	0d1a285129	(core) Fix changing type of source column from choice to choicelist Summary: Updates the summary column type correctly, rebuilds the table model Test Plan: Added a python unit test, tested manually in browser Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2973	3 years ago
Alex Hall	ffeab944cc	(core) Fix detaching summary tables grouped by list column Summary: Detached formula uses CONTAINS() Test Plan: Added to existing unit test Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2972	3 years ago
Alex Hall	04e5d90f86	(core) Barely working reference lists in frontend Summary: This makes it possible to set the type of a column to ReferenceList, but the UI is terrible ReferenceList.ts is a mishmash of ChoiceList and Reference that sort of works but something about the CSS is clearly broken ReferenceListEditor is just a text editor, you have to type in a JSON array of row IDs. Ignore the value that's present when you start editing. I can maybe try mashing together ReferenceEditor and ChoiceListEditor but it doesn't seem wise. I think @georgegevoian should take over here. Reviewing the diff as it is to check for obvious issues is probably good but I don't think it's worth trying to land/merge anything. Test Plan: none Reviewers: dsagal Reviewed By: dsagal Subscribers: georgegevoian Differential Revision: https://phab.getgrist.com/D2914	3 years ago
Alex Hall	f7a9638992	(core) CONTAINS() and summarising by ChoiceList columns with flattening Summary: Added CONTAINS 'function' which can be used in lookups Changed LookupMapColumn._row_key_map to use right=set so one row can have many keys when CONTAINS is used. Use CONTAINS to implement group column in summary table, while helper column in source table can reference and create multiple rows in summary table, especially when summarising by ChoiceList columns. Use itertools.product to generate all combinations of lookup keys and groupby values. cleanup Test Plan: Added python unit tests. Reviewers: dsagal Reviewed By: dsagal Subscribers: paulfitz, dsagal Differential Revision: https://phab.getgrist.com/D2900	3 years ago
Dmitry S	01cef034ed	(core) A quick attempt to fix summarizing by reference columns Test Plan: TBD Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2884	3 years ago
Alex Hall	16f297a250	(core) Simple Python 3 compatibility changes Summary: Changes that move towards python 3 compatibility that are easy to review without much thought Test Plan: The tests Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2873	3 years ago
Paul Fitzpatrick	b82eec714a	(core) move data engine code to core Summary: this moves sandbox/grist to core, and adds a requirements.txt file for reconstructing the content of sandbox/thirdparty. Test Plan: existing tests pass. Tested core functionality manually. Tested docker build manually. Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2563	4 years ago

12 Commits (1c6f80f956dcf5e1522caa1be518a151f850c041)