gristlabs_grist-core

Commit Graph

Author	SHA1	Message	Date
Dmitry S	de1719ee08	(core) Make side panels responsive and start closed on small screens. Summary: - Add isNarrowScreenObs() observable. - Remove optimizeNarrowScreen flag (now assumed always true). - Added viewport support and mobile tweaks to Error/Billing/Welcome pages. - Fix responsiveness of panel transitions, and of side panel state. - Close left panel on navigation to another page or workspace. - Start panels collapsed in both doc and docmenu cases. Test Plan: Tested manually, and fixed tests to accept the new behavior. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2726	4 years ago
Cyprien P	710014ce54	(core) Animate side panels Summary: Diff makes side panels slide horizontally when opening/closing them. Caveats: . Right panel: even though the panel do transition nicely, the content however disappears suddently. We could prevent disposal of the dom by removing the two below lines. But it's hard to tell what possible side effect we could get from it as I don't know why these line were added in the first place. I could investigate further, but maybe it's already good enough as it is. ``` private _buildContentDom() { return dom.domComputed((use) => { // if (!use(this._isOpen)) { return null; } // remove line const tool = use(this._extraTool); ``` ``` private _buildHeaderDom() { return dom.domComputed((use) => { // if (!use(this._isOpen)) { return null; } // remove line const tool = use(this._extraTool); return tool ? this._buildToolHeader(tool) : this._buildStandardHeader(); ``` Test Plan: Tested manually on desktop environnment with FF and chrome by shrinking the window. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2710	4 years ago
Dmitry S	586b6568af	(core) Add viewport meta tag conditionally, and show a toggle for it on small devices. Summary: - Enable narrow-screen layout for home page - Clean up margins/spacing on small-screen home page - Use "<768" as small-screen condition rather than "<=768". - Include meta-viewport tag conditionally, off by default. - Include "Toggle Mobile Mode" option in AccountMenu to toggle it on. - In a test, add an after() clause to restore window size even when test fails Test Plan: Only tested manually on iPhone (Safari & FF). Reviewers: paulfitz Reviewed By: paulfitz Subscribers: cyprien Differential Revision: https://phab.getgrist.com/D2708	4 years ago
Cyprien P	eb90385ee9	(core) Keeps side panels closed when opening doc on a narrow screen Test Plan: Includes nbrowser tests. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2709	4 years ago
Cyprien P	4cd9a2d740	(core) Making side bars a bit more usable for narrow screen Summary: - closes side bars when tapping content area - opens left panel when tapping the page name Test Plan: Includes browser tests. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2705	4 years ago
Cyprien P	ffe4a34335	(core) Adds current page name to the bottom bar [narrow screen] Test Plan: Tested Manually, behave well also for long page name. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2702	4 years ago
Cyprien P	4ca1c09e35	(core) Adds scafoldings for the narrow screen layout Summary: This commit adds a bottom bar with 2 openers button for each side panels. It takes care of showing/hiding other openers when appropriate. It also implements the new style for narrow screen with the side panels overlapping the main pane. Remaining tasks: - adjust content of the breadcrumbs for narrow screen. - content of the bottom bar Test Plan: Adds test to projects/PagePanels Reviewers: paulfitz Reviewed By: paulfitz Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D2701	4 years ago
Paul Fitzpatrick	1654a2681f	(core) move client code to core Summary: This moves all client code to core, and makes minimal fix-ups to get grist and grist-core to compile correctly. The client works in core, but I'm leaving clean-up around the build and bundles to follow-up. Test Plan: existing tests pass; server-dev bundle looks sane Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2627	4 years ago

8 Commits (11c944d794747bf00256facca11950332dd40b3c)