mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) clean up a collection of small problems affecting grist-core
Summary: * Remove adjustSession hack, interfering with loading docs under saml. * Allow the anonymous user to receive an empty list of workspaces for the merged org. * Behave better on first page load when org is in path - this used to fail because of lack of cookie. This is very visible in grist-core, as a failure to load localhost:8484 on first visit. * Mark cookie explicitly as SameSite=Lax to remove a warning in firefox. * Make errorPages available in grist-core. This changes the default behavior of grist-core to now start off in anonymous mode, with an explicit sign-in step available. If SAML is not configured, the sign-in operation will unconditionally sign the user in as a default user, without any password check or other security. The user email is taken from GRIST_DEFAULT_EMAIL if set. This is a significant change, but makes anonymous mode available in grist-core (which is convenient for testing) and makes behavior with and without SAML much more consistent. Test Plan: updated test; manual (time to start adding grist-core tests though!) Reviewers: dsagal Reviewed By: dsagal Differential Revision: https://phab.getgrist.com/D2980
This commit is contained in:
@@ -774,7 +774,10 @@ export class HomeDBManager extends EventEmitter {
|
||||
public async getOrgWorkspaces(scope: Scope, orgKey: string|number,
|
||||
options: QueryOptions = {}): Promise<QueryResult<Workspace[]>> {
|
||||
const query = this._orgWorkspaces(scope, orgKey, options);
|
||||
const result = await this._verifyAclPermissions(query, { scope });
|
||||
// Allow an empty result for the merged org for the anonymous user. The anonymous user
|
||||
// has no home org or workspace. For all other sitations, expect at least one workspace.
|
||||
const emptyAllowed = this.isMergedOrg(orgKey) && scope.userId === this.getAnonymousUserId();
|
||||
const result = await this._verifyAclPermissions(query, { scope, emptyAllowed });
|
||||
// Return the workspaces, not the org(s).
|
||||
if (result.status === 200) {
|
||||
// Place ownership information in workspaces, available for the merged org.
|
||||
|
||||
Reference in New Issue
Block a user