Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) Add GRIST_UI_FEATURES env variable

Browse Source 
Summary:
Tutorials are now hidden by default in grist-core and grist-ee, and can
be re-enabled via a new env variable, GRIST_UI_FEATURES, which accepts
a comma-separated list of UI features to enable.

Test Plan: Browser tests.

Reviewers: jarek

Reviewed By: jarek

Subscribers: jarek

Differential Revision: https://phab.getgrist.com/D3885
This commit is contained in:
George Gevoian
2023-05-20 19:58:41 -04:00
parent 1e873b4203
commit f18bb3e39d
14 changed files with 105 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
test/nbrowser/Features.ts Normal file
View File

@@ -0,0 +1,51 @@
import { assert, driver } from 'mocha-webdriver';
import * as gu from 'test/nbrowser/gristUtils';
import { server, setupTestSuite } from 'test/nbrowser/testUtils';
import { EnvironmentSnapshot } from 'test/server/testUtils';
describe('Features', function () {
this.timeout(20000);
setupTestSuite();
let session: gu.Session;
let oldEnv: EnvironmentSnapshot;
before(async function () {
oldEnv = new EnvironmentSnapshot();
session = await gu.session().teamSite.login();
});
after(async function () {
oldEnv.restore();
await server.restart();
});
it('can be enabled with the GRIST_UI_FEATURES env variable', async function () {
process.env.GRIST_UI_FEATURES = 'helpCenter,templates';
await server.restart();
await session.loadDocMenu('/');
assert.isTrue(await driver.find('.test-dm-templates-page').isDisplayed());
assert.isTrue(await driver.find('.test-left-feedback').isDisplayed());
assert.isFalse(await driver.find('.test-dm-basic-tutorial').isDisplayed());
});
it('can be disabled with the GRIST_HIDE_UI_ELEMENTS env variable', async function () {
delete process.env.GRIST_UI_FEATURES;
process.env.GRIST_HIDE_UI_ELEMENTS = 'templates';
await server.restart();
await session.loadDocMenu('/');
assert.isTrue(await driver.find('.test-left-feedback').isDisplayed());
assert.isTrue(await driver.find('.test-dm-basic-tutorial').isDisplayed());
assert.isFalse(await driver.find('.test-dm-templates-page').isDisplayed());
});
it('that are disabled take precedence if also enabled', async function () {
process.env.GRIST_UI_FEATURES = 'tutorials,templates';
process.env.GRIST_HIDE_UI_ELEMENTS = 'helpCenter,templates';
await server.restart();
await session.loadDocMenu('/');
assert.isTrue(await driver.find('.test-dm-basic-tutorial').isDisplayed());
assert.isFalse(await driver.find('.test-left-feedback').isPresent());
assert.isFalse(await driver.find('.test-dm-templates-page').isDisplayed());
});
});