Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) JS error on creator panel and formula editor.

Browse Source 
Summary:
Fixing js error that happens when closing creator panel with active formula editor.

Styling behavior menu with common styles.

Test Plan: Browser tests

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D3150
This commit is contained in:
Jarosław Sadziński
2021-11-30 09:59:04 +01:00
parent 551ea28fc4
commit e482427e83
6 changed files with 52 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
app/client/components/GristDoc.ts
View File

@@ -625,10 +625,19 @@ export class GristDoc extends DisposableWithEvents {
);
}
// Convert column to pure formula column.
public async convertToFormula(colRefs: number, formula: string): Promise<void> {
// Updates formula for a column.
public async updateFormula(colRef: number, formula: string): Promise<void> {
return this.docModel.columns.sendTableAction(
['UpdateRecord', colRefs, {
['UpdateRecord', colRef, {
formula,
}]
);
}
// Convert column to pure formula column.
public async convertToFormula(colRef: number, formula: string): Promise<void> {
return this.docModel.columns.sendTableAction(
['UpdateRecord', colRef, {
isFormula: true,
formula,
recalcWhen: RecalcWhen.DEFAULT,