(core) Add new UI for writing memos

Summary:
Adds a new UI for writing access rule memos.

Migrates old memos (written as Python comments) to the new UI.

Test Plan: Browser and migration tests.

Reviewers: jarek, dsagal

Reviewed By: jarek

Subscribers: dsagal, paulfitz

Differential Revision: https://phab.getgrist.com/D3726
This commit is contained in:
George Gevoian
2022-12-12 01:29:20 -05:00
parent aaf32ece50
commit e146f95c1c
14 changed files with 233 additions and 53 deletions

View File

@@ -454,7 +454,7 @@ function readAclRules(docData: DocData, {log, compile, includeHelperCols}: ReadA
origRecord: rule,
aclFormula: String(rule.aclFormula),
matchFunc: rule.aclFormula ? compile?.(aclFormulaParsed) : defaultMatchFunc,
memo: aclFormulaParsed && aclFormulaParsed[0] === 'Comment' && aclFormulaParsed[2],
memo: rule.memo,
permissions: parsePermissions(String(rule.permissionsText)),
permissionsText: String(rule.permissionsText),
});

View File

@@ -4,7 +4,7 @@ import { GristObjCode } from "app/plugin/GristData";
// tslint:disable:object-literal-key-quotes
export const SCHEMA_VERSION = 34;
export const SCHEMA_VERSION = 35;
export const schema = {
@@ -170,6 +170,7 @@ export const schema = {
permissionsText : "Text",
rulePos : "PositionNumber",
userAttributes : "Text",
memo : "Text",
},
"_grist_ACLResources": {
@@ -374,6 +375,7 @@ export interface SchemaTypes {
permissionsText: string;
rulePos: number;
userAttributes: string;
memo: string;
};
"_grist_ACLResources": {