Summary: This turns out necessary because ReferenceList columns are formatted using the formatter of the associated visibleCol. This works correctly in dedicated widgets, but in generic code (like SearchModel here), this formatter needs to handle unexpected values (of type ReferenceList). Without the fix, it produces JS errors when search reaches a RefList:<Date> column. A better fix would allow a formatter to know that it expects a ReferenceList, AND to know how to format each value of it, but that's a bigger question that's outside the scope of this fix. Test Plan: Includes a browser test which reproduces the bug. Reviewers: cyprien Reviewed By: cyprien Differential Revision: https://phab.getgrist.com/D3195pull/118/head
parent
c1de16aee7
commit
e0fb281eba
Loading…
Reference in new issue