mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Checks that an ACL formula can be parsed, and prevent saving unparsable ACL rules.
Summary: - Fix error-handling in bundleActions(), and wait for the full bundle to complete. (The omissions here were making it impossibly to react to errors from inside bundleActions()) - Catch problematic rules early enough to undo them, by trying out ruleCollection.update() on updated rules before the updates are applied. - Added checkAclFormula() call to DocComm that checks parsing and compiling formula, and reports errors. - In UI, prevent saving if any aclFormulas are invalid, or while waiting for the to get checked. - Also fixed some lint errors Test Plan: Added a test case of error reporting in ACL formulas. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2689
This commit is contained in:
@@ -19,7 +19,7 @@ import {WorkCoordinator} from './WorkCoordinator';
|
||||
// processing hub actions or rebasing.
|
||||
interface UserRequest {
|
||||
action: UserActionBundle;
|
||||
docSession: OptDocSession|null,
|
||||
docSession: OptDocSession|null;
|
||||
resolve(result: UserResult): void;
|
||||
reject(err: Error): void;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user