Summary: This verifies that all existing tests are capable of running under python3/gvisor, and fixes the small issues that came up. It does not yet activate python3 tests on all diffs, only diffs that specifically request them. * Adds a suffix in test names and output directories for tests run with PYTHON_VERSION=3, so that results of the same test run with and without the flag can be aggregated cleanly. * Adds support for checkpointing to the gvisor sandbox adapter. * Prepares a checkpoint made after grist python code has loaded in the gvisor sandbox. * Changes how `DOC_URL` is passed to the sandbox, since it can no longer be passed in as an environment variable when using checkpoints. * Uses the checkpoint to speed up tests using the gvisor sandbox, otherwise a lot of tests need more time (especially on mac under docker). * Directs jenkins to run all tests with python2 and python3 when a new file `buildtools/changelogs/python.txt` is touched (this diff counts as touching that file). * Tweaks miscellaneous tests - some needed fixes exposed by slightly different timing - a small number actually give different results in py3 (removal of `u` prefixes). - some needed a little more time The DOC_URL change is not the ultimate solution we want for DOC_URL. Eventually it should be a variable that gets updated, like the date perhaps. This is just a small pragmatic change to preserve existing behavior. Tests are run mindlessly as py3, and for some tests it won't change anything (e.g. if they do not use NSandbox). Tests are not run in parallel, doubling overall test time. Checkpoints could be useful in deployment, though this diff doesn't use them there. The application of checkpoints doesn't check for other configuration like 3-versus-5-pipe that we don't actually use. Python2 tests run using pynbox as always for now. The diff got sufficiently bulky that I didn't tackle running py3 on "regular" diffs in it. My preference, given that most tests don't appear to stress the python side of things, would be to make a selection of the tests that do and a few wild cards, and run those tests on both pythons rather then all of them. For diffs making a significant python change, I'd propose touching buildtools/changelogs/python.txt for full tests. But this is a conversation in progress. A total of 6886 tests ran on this diff. Test Plan: this is a step in preparing tests for py3 transition Reviewers: dsagal Reviewed By: dsagal Subscribers: dsagal Differential Revision: https://phab.getgrist.com/D3066pull/115/head
Paul Fitzpatrick
3 years ago
parent
3e661db38c
commit
dd0f1be117
@ -0,0 +1,28 @@
|
||||
/**
|
||||
*
|
||||
* This opens a sandbox in order to capture a checkpoint of the sandbox after Grist
|
||||
* python code has been loaded within it. This helps run Grist's 1000s of tests under
|
||||
* gvisor on a ptrace platform, for which all the file accesses on sandbox startup
|
||||
* are relatively slow, adding about a second relative to pynbox.
|
||||
*
|
||||
*/
|
||||
|
||||
import { create } from 'app/server/lib/create';
|
||||
|
||||
export async function main() {
|
||||
if (!process.env.GRIST_CHECKPOINT) {
|
||||
throw new Error('GRIST_CHECKPOINT must be defined');
|
||||
}
|
||||
if (!process.env.GRIST_CHECKPOINT_MAKE) {
|
||||
throw new Error('GRIST_CHECKPOINT_MAKE must be defined');
|
||||
}
|
||||
create.NSandbox({
|
||||
preferredPythonVersion: '3'
|
||||
});
|
||||
}
|
||||
|
||||
if (require.main === module) {
|
||||
main().catch(e => {
|
||||
console.error(e);
|
||||
});
|
||||
}
|
||||
Loading…
Reference in new issue