mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Floating formula editor
Summary: Adding a way to detach an editor. Initially only implemented for the formula editor, includes redesign for the AI part. - Initially, the detached editor is tight with the formula assistant and both are behind GRIST_FORMULA_ASSISTANT flag, but this can be relaxed later on, as the detached editor can be used on its own. - Detached editor is only supported in regular fields and on the creator panel. It is not supported yet for conditional styles, due to preview limitations. - Old code for the assistant was removed completely, as it was only a temporary solution, but the AI conversation part was copied to the new one. - Prompting was not modified in this diff, it will be included in the follow-up with more test cases. Test Plan: Added only new tests; existing tests should pass. Reviewers: JakubSerafin Reviewed By: JakubSerafin Differential Revision: https://phab.getgrist.com/D3863
This commit is contained in:
@@ -249,7 +249,7 @@ function toggleDisabled(boolValueOrFunc) {
|
||||
exports.toggleDisabled = toggleDisabled;
|
||||
|
||||
/**
|
||||
* Adds a css class named by an observable value. If the value changes, the previous class will be
|
||||
* Adds a css class (one or many) named by an observable value. If the value changes, the previous class will be
|
||||
* removed and the new one added. The value may be empty to avoid adding any class.
|
||||
* Similar to knockout's `css` binding with a dynamic class.
|
||||
* @param {Object} valueOrFunc An observable, a constant, or a function for a computed observable.
|
||||
@@ -258,11 +258,15 @@ function cssClass(valueOrFunc) {
|
||||
var prevClass;
|
||||
return makeBinding(valueOrFunc, function(elem, value) {
|
||||
if (prevClass) {
|
||||
elem.classList.remove(prevClass);
|
||||
for(const name of prevClass.split(' ')) {
|
||||
elem.classList.remove(name);
|
||||
}
|
||||
}
|
||||
prevClass = value;
|
||||
if (value) {
|
||||
elem.classList.add(value);
|
||||
for (const name of value.split(' ')) {
|
||||
elem.classList.add(name);
|
||||
}
|
||||
}
|
||||
});
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user