Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fix scrolling in Raw Data page, and tweak background of selection-summary in Raw Data tables to look better

Browse Source 
Test Plan: Tested manually, doesn't seem worth a dedicated test.

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D3653
This commit is contained in:
Dmitry S 2022-10-05 10:59:39 -04:00
parent 74c556ea85
commit d3d50cdca8
2 changed files with 18 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
app/client/components/GristDoc.ts
View File

@ -839,21 +839,6 @@ export class GristDoc extends DisposableWithEvents {
return this.docPageModel.appModel.api.getDocAPI(this.docId()).getDownloadXlsxUrl(params); return this.docPageModel.appModel.api.getDocAPI(this.docId()).getDownloadXlsxUrl(params);
} }
private _getDocApiDownloadParams() {
const filters = this.viewModel.activeSection.peek().activeFilters.get().map(filterInfo => ({
colRef : filterInfo.fieldOrColumn.origCol().origColRef(),
filter : filterInfo.filter()
}));
const params = {
viewSection: this.viewModel.activeSectionId(),
tableId: this.viewModel.activeSection().table().tableId(),
activeSortSpec: JSON.stringify(this.viewModel.activeSection().activeSortSpec()),
filters : JSON.stringify(filters),
};
return params;
}
public hasGranularAccessRules(): boolean { public hasGranularAccessRules(): boolean {
const rulesTable = this.docData.getMetaTable('_grist_ACLRules'); const rulesTable = this.docData.getMetaTable('_grist_ACLRules');
// To check if there are rules, ignore the default no-op rule created for an older incarnation // To check if there are rules, ignore the default no-op rule created for an older incarnation
@ -1151,6 +1136,21 @@ export class GristDoc extends DisposableWithEvents {
} }
} }
private _getDocApiDownloadParams() {
const filters = this.viewModel.activeSection.peek().activeFilters.get().map(filterInfo => ({
colRef : filterInfo.fieldOrColumn.origCol().origColRef(),
filter : filterInfo.filter()
}));
const params = {
viewSection: this.viewModel.activeSectionId(),
tableId: this.viewModel.activeSection().table().tableId(),
activeSortSpec: JSON.stringify(this.viewModel.activeSection().activeSortSpec()),
filters : JSON.stringify(filters),
};
return params;
}
/** /**
* Switch to a given sectionId, wait for it to load, and return a Promise for the instantiated * Switch to a given sectionId, wait for it to load, and return a Promise for the instantiated
* viewInstance (such as an instance of GridView or DetailView). * viewInstance (such as an instance of GridView or DetailView).
@ -1278,5 +1278,6 @@ const cssViewContentPane = styled('div', `
} }
&-contents { &-contents {
margin: 0px; margin: 0px;
overflow: hidden;
} }
`); `);

4
app/client/components/SelectionSummary.ts
View File

@ -276,8 +276,6 @@ const cssSummary = styled('div', `
width: 100%; width: 100%;
justify-content: end; justify-content: end;
color: ${theme.text}; color: ${theme.text};
/* Small hack: override the backdrop when viewing raw data to improve visibility. */
background-color: ${theme.mainPanelBg};
font-family: ${vars.fontFamilyData}; font-family: ${vars.fontFamilyData};
@media print { @media print {
@ -300,6 +298,8 @@ const cssSummaryPart = styled('div', `
overflow: hidden; overflow: hidden;
text-overflow: ellipsis; text-overflow: ellipsis;
white-space: nowrap; white-space: nowrap;
/* Set explicit backdrop to improve visibility in raw data views. */
background-color: ${theme.mainPanelBg};
&-copyable:hover { &-copyable:hover {
cursor: pointer; cursor: pointer;