Fixed row-delete bug

If several sections cyclically cursor-linked, and a row
was deleted, the sections would go to different places.

(default behavior on row delete is jump to row 0, but active
section's cursor explicitly keeps its index on row-delete.
The setCursorPos from this WAS actually called last, so should
have correctly set cursorEdited(), but didn't get called)
This commit is contained in:
Janet Vorobyeva 2023-09-19 00:03:44 -07:00
parent 7b193c62a6
commit d3800564d8

View File

@ -183,6 +183,17 @@ export class Cursor extends Disposable {
this.fieldIndex(cursorPos.fieldIndex);
}
// NOTE: cursorEdited
// We primarily update cursorEdited counter from a this._properRowId.subscribe(), since that catches updates
// from many sources (setCursorPos, arrowKeys, save/load, filter/sort-changes, etc)
// However, when deleting a row with several sections linked together, there can be a case where this fails:
// When GridView.deleteRows calls setCursorPos to keep cursor from jumping after delete, the observable
// doesn't trigger cursorEdited(), because (I think) _properRowId has already been updated that cycle.
// This caused a bug when several viewSections were cursor-linked to each other and a row was deleted.
// We can explicitly call cursorEdited again here. It'll cause cursorEdited to be called twice sometimes,
// but that shouldn't cause any problems, since we don't care about edit counts, just who was edited latest.
this.cursorEdited()
} finally { // Make sure we reset this even on error
this._silentUpdatesFlag = false;
}