(core) Add rules to eslint to better match our coding conventions.

Summary:
We used tslint earlier, and on switching to eslint, some rules were not
transfered. This moves more rules over, for consistent conventions or helpful
warnings.

- Name private members with a leading underscore.
- Prefer interface over a type alias.
- Use consistent spacing around ':' in type annotations.
- Use consistent spacing around braces of code blocks.
- Use semicolons consistently at the ends of statements.
- Use braces around even one-liner blocks, like conditionals and loops.
- Warn about shadowed variables.

Test Plan: Fixed all new warnings. Should be no behavior changes in code.

Reviewers: paulfitz

Reviewed By: paulfitz

Differential Revision: https://phab.getgrist.com/D2831

app/client/ui2018/ColorSelect.ts

@@ -82,7 +82,7 @@ function buildColorPicker(ctl: IOpenController, textColor: Observable<string>, f
     }),
 
     // gives focus and binds keydown events
-    (elem: any) => {setTimeout(() => elem.focus(), 0); },
+    (elem: any) => { setTimeout(() => elem.focus(), 0); },
     onKeyDown({
       Escape: () => { revert(); },
       Enter: () => { ctl.close(); },
@@ -158,7 +158,7 @@ class PickerComponent extends Disposable {
           ),
           cssHexBox(
             this._color,
-            async (val) => { if (isValidHex(val)) {this._model.setValue(val); }},
+            async (val) => { if (isValidHex(val)) { this._model.setValue(val); } },
             testId(`${title}-hex`),
             // select the hex value on click. Doing it using settimeout allows to avoid some
             // sporadically losing the selection just after the click.

app/client/ui2018/editableLabel.ts

@@ -105,7 +105,7 @@ export function rawTextInput(value: Observable<string>, save: SaveFunc, onChange
   let inputEl: HTMLInputElement;
 
   // When label changes updates the input, unless in the middle of editing.
-  const lis = value.addListener((val) => { if (status !== Status.EDITING) { setValue(val); }});
+  const lis = value.addListener((val) => { if (status !== Status.EDITING) { setValue(val); } });
 
   function setValue(val: string) {
     inputEl.value = val;

app/client/ui2018/search.ts

@@ -128,8 +128,8 @@ export function searchBar(model: SearchModel, testId: TestId = noTestId) {
     find: () => { inputElem.focus(); inputElem.select(); },
     // On Mac, Firefox has a default behaviour witch causes to close the search bar on Cmd+g and
     // Cmd+shirt+G. Returning false is a Mousetrap convenience which prevents that.
-    findNext: () => {model.findNext().catch(reportError); return false; },
-    findPrev: () => {model.findPrev().catch(reportError); return false; },
+    findNext: () => { model.findNext().catch(reportError); return false; },
+    findPrev: () => { model.findPrev().catch(reportError); return false; },
   }, null, true);
 
   const toggleMenu = debounce((_value?: boolean) => {