Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) tweak description of FullCopies special permission

Browse Source 
Summary: This mentions fiddle mode in FullCopies special permission.

Test Plan: visual, existing tests pass

Reviewers: dsagal

Reviewed By: dsagal

Differential Revision: https://phab.getgrist.com/D2952
This commit is contained in:
Paul Fitzpatrick 2021-07-29 16:28:50 -04:00
parent 931827b195
commit d09c2f1b3d
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/client/aclui/AccessRules.ts
View File

@ -904,9 +904,10 @@ class DefaultObsRuleSet extends ObsRuleSet {
function getSpecialRuleDescription(type: string): string { function getSpecialRuleDescription(type: string): string {
switch (type) { switch (type) {
case 'AccessRules': case 'AccessRules':
return 'Allow everyone to view Access Rules'; return 'Allow everyone to view Access Rules.';
case 'FullCopies': case 'FullCopies':
return 'Allow everyone to download and copy the full document even if they have incomplete access to it'; return 'Allow everyone to copy the entire document, or view it in full in fiddle mode.\n' +
'Useful for examples and templates, but not for sensitive data.';
default: return type; default: return type;
} }
} }
@ -914,7 +915,7 @@ function getSpecialRuleDescription(type: string): string {
function getSpecialRuleName(type: string): string { function getSpecialRuleName(type: string): string {
switch (type) { switch (type) {
case 'AccessRules': return 'Permission to view Access Rules'; case 'AccessRules': return 'Permission to view Access Rules';
case 'FullCopies': return 'Permission to download and copy the document in full'; case 'FullCopies': return 'Permission to access the document in full when needed';
default: return type; default: return type;
} }
} }
@ -934,6 +935,7 @@ class SpecialObsRuleSet extends ColumnObsRuleSet {
dom.autoDispose(isExpanded), dom.autoDispose(isExpanded),
dom.autoDispose(allowEveryone), dom.autoDispose(allowEveryone),
cssRuleDescription( cssRuleDescription(
{style: 'white-space: pre-line;'}, // preserve line breaks in long descriptions
cssIconButton(icon('Expand'), cssIconButton(icon('Expand'),
dom.style('transform', (use) => use(isExpanded) ? 'rotate(90deg)' : ''), dom.style('transform', (use) => use(isExpanded) ? 'rotate(90deg)' : ''),
dom.on('click', () => isExpanded.set(!isExpanded.get())), dom.on('click', () => isExpanded.set(!isExpanded.get())),