Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Allow descriptions for Raw Data tables

Browse Source 
Summary: Descriptions can now be set on Raw Data table sections.

Test Plan: Browser tests.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D4131
This commit is contained in:
George Gevoian 2023-11-29 12:59:34 -05:00
parent 887717bb15
commit cc56e91f5b
4 changed files with 46 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/client/components/DataTables.ts
View File

@ -482,5 +482,6 @@ const cssFlexRow = styled('div', `
`);
const cssRenamableTableName = styled('div', `
align-items: center;
flex: initial;
`);

2
sandbox/grist/useractions.py
View File

@ -460,7 +460,7 @@ class UserActions(object):
table_id == "_grist_Views_section"
and any(rec.isRaw for i, rec in self._bulk_action_iter(table_id, row_ids))
):
allowed_fields = {"title", "options", "sortColRefs", "rules"}
allowed_fields = {"title", "description", "options", "sortColRefs", "rules"}
has_summary_section = any(rec.tableRef.summarySourceTable
for i, rec in self._bulk_action_iter(table_id, row_ids))
if has_summary_section:

30
test/nbrowser/RawData.ts
View File

@ -108,6 +108,36 @@ describe('RawData', function () {
assert.deepEqual(tables, ['Town', 'Empire', 'CountryLanguage', 'Table1'].sort());
});
it('should show table description', async function () {
// Give Empire table a description.
await gu.renameRawTable('Empire', undefined, 'My raw data table description.');
// Check that a description icon tooltip is shown next to the title.
await driver.findContent('.test-raw-data-table-title', 'Empire')
.find('.test-widget-info-tooltip')
.click();
await gu.waitToPass(async () => {
assert.isTrue(await driver.find('.test-widget-info-tooltip-popup').isDisplayed());
});
assert.equal(
await driver.find('.test-widget-info-tooltip-popup').getText(),
'My raw data table description.'
);
// Open Empire table and check that the tooltip is shown there as well.
await driver.findContent('.test-raw-data-table-title', 'Empire').click();
await gu.waitForServer();
await driver.find('.test-viewsection-title .test-widget-info-tooltip').click();
await gu.waitToPass(async () => {
assert.isTrue(await driver.find('.test-widget-info-tooltip-popup').isDisplayed());
});
assert.equal(
await driver.find('.test-widget-info-tooltip-popup').getText(),
'My raw data table description.'
);
await gu.closeRawTable();
});
it('should remove table', async function () {
// Open menu for Town
await openMenu('Town');

19
test/nbrowser/gristUtils.ts
View File

@ -1531,16 +1531,25 @@ export async function openRawTable(tableId: string) {
await driver.find(`.test-raw-data-table .test-raw-data-table-id-${tableId}`).click();
}
export async function renameRawTable(tableId: string, newName: string) {
export async function renameRawTable(tableId: string, newName?: string, newDescription?: string) {
await driver.find(`.test-raw-data-table .test-raw-data-table-id-${tableId}`)
.findClosest('.test-raw-data-table')
.find('.test-raw-data-table-menu')
.click();
await driver.find('.test-raw-data-menu-rename-table').click();
const input = await driver.find(".test-widget-title-table-name-input");
await input.doClear();
await input.click();
await driver.sendKeys(newName, Key.ENTER);
if (newName !== undefined) {
const input = await driver.find(".test-widget-title-table-name-input");
await input.doClear();
await input.click();
await driver.sendKeys(newName);
}
if (newDescription !== undefined) {
const input = await driver.find(".test-widget-title-section-description-input");
await input.doClear();
await input.click();
await driver.sendKeys(newDescription);
}
await driver.find(".test-widget-title-save").click();
await waitForServer();
}