Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fix reporting of blank attachment types

Browse Source 
Summary:
The conditions in the map/filter of attachments was faulty, causing
blank attachment types to slip through.

Test Plan: Tested manually.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3865
This commit is contained in:
George Gevoian 2023-04-19 00:27:18 -04:00
parent b15ae98349
commit c077f3c304
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/server/lib/ActiveDoc.ts
View File

@ -2326,8 +2326,9 @@ export class ActiveDoc extends EventEmitter {
const attachments = this.docData?.getMetaTable('_grist_Attachments'); const attachments = this.docData?.getMetaTable('_grist_Attachments');
const numAttachments = attachments?.numRecords() ?? 0; const numAttachments = attachments?.numRecords() ?? 0;
const attachmentTypes = attachments?.getRecords() const attachmentTypes = attachments?.getRecords()
.map(r => r.fileExt?.slice(1) ?? null) // Exclude the leading ".", if any.
.filter(ext => ext !== null); .map(r => r.fileExt?.trim()?.slice(1))
.filter(ext => Boolean(ext));
return { return {
numAttachments, numAttachments,