Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

Fix Features and DocTutorial tests (#520)

Browse Source
This commit is contained in:
George Gevoian 2023-05-23 14:34:48 -04:00 committed by GitHub
parent 4cc19ff748
commit bd474a382f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
test/nbrowser/DocTutorial.ts
View File

@ -2,7 +2,8 @@ import {DocCreationInfo} from 'app/common/DocListAPI';
import {UserAPI} from 'app/common/UserAPI'; import {UserAPI} from 'app/common/UserAPI';
import {assert, driver, Key} from 'mocha-webdriver'; import {assert, driver, Key} from 'mocha-webdriver';
import * as gu from 'test/nbrowser/gristUtils'; import * as gu from 'test/nbrowser/gristUtils';
import {setupTestSuite} from 'test/nbrowser/testUtils'; import {server, setupTestSuite} from 'test/nbrowser/testUtils';
import {EnvironmentSnapshot} from 'test/server/testUtils';
describe('DocTutorial', function () { describe('DocTutorial', function () {
this.timeout(30000); this.timeout(30000);
@ -11,10 +12,14 @@ describe('DocTutorial', function () {
let doc: DocCreationInfo; let doc: DocCreationInfo;
let api: UserAPI; let api: UserAPI;
let session: gu.Session; let session: gu.Session;
let oldEnv: EnvironmentSnapshot;
const cleanup = setupTestSuite({team: true}); const cleanup = setupTestSuite({team: true});
before(async () => { before(async () => {
oldEnv = new EnvironmentSnapshot();
process.env.GRIST_UI_FEATURES = 'tutorials';
await server.restart();
session = await gu.session().teamSite.user('support').login(); session = await gu.session().teamSite.user('support').login();
doc = await session.tempDoc(cleanup, 'DocTutorial.grist'); doc = await session.tempDoc(cleanup, 'DocTutorial.grist');
api = session.createHomeApi(); api = session.createHomeApi();
@ -25,6 +30,11 @@ describe('DocTutorial', function () {
}}); }});
}); });
after(async function () {
oldEnv.restore();
await server.restart();
});
describe('when logged out', function () { describe('when logged out', function () {
before(async () => { before(async () => {
session = await gu.session().anon.login(); session = await gu.session().anon.login();

4
test/nbrowser/Features.ts
View File

@ -30,7 +30,7 @@ describe('Features', function () {
}); });
it('can be disabled with the GRIST_HIDE_UI_ELEMENTS env variable', async function () { it('can be disabled with the GRIST_HIDE_UI_ELEMENTS env variable', async function () {
delete process.env.GRIST_UI_FEATURES; process.env.GRIST_UI_FEATURES = 'helpCenter,tutorials';
process.env.GRIST_HIDE_UI_ELEMENTS = 'templates'; process.env.GRIST_HIDE_UI_ELEMENTS = 'templates';
await server.restart(); await server.restart();
await session.loadDocMenu('/'); await session.loadDocMenu('/');
@ -39,7 +39,7 @@ describe('Features', function () {
assert.isFalse(await driver.find('.test-dm-templates-page').isDisplayed()); assert.isFalse(await driver.find('.test-dm-templates-page').isDisplayed());
}); });
it('that are disabled take precedence if also enabled', async function () { it('that are disabled take precedence over those that are also enabled', async function () {
process.env.GRIST_UI_FEATURES = 'tutorials,templates'; process.env.GRIST_UI_FEATURES = 'tutorials,templates';
process.env.GRIST_HIDE_UI_ELEMENTS = 'helpCenter,templates'; process.env.GRIST_HIDE_UI_ELEMENTS = 'helpCenter,templates';
await server.restart(); await server.restart();