Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fixing UserProfile test that fails randomly

Browse Source 
Summary: UserProfile test fails randomly which is caused by the AccountWidget that loads its data asonchrynously.

Test Plan: Existing tests

Reviewers: dsagal

Reviewed By: dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D2964
This commit is contained in:
Jarosław Sadziński 2021-08-05 17:45:16 +02:00
parent 6ed1d8dfea
commit bb55422d9c
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/nbrowser/gristUtils.ts
View File

@ -42,7 +42,6 @@ export const removeLogin = homeUtil.removeLogin.bind(homeUtil);
export const setValue = homeUtil.setValue.bind(homeUtil); export const setValue = homeUtil.setValue.bind(homeUtil);
export const isOnLoginPage = homeUtil.isOnLoginPage.bind(homeUtil); export const isOnLoginPage = homeUtil.isOnLoginPage.bind(homeUtil);
export const checkLoginPage = homeUtil.checkLoginPage.bind(homeUtil); export const checkLoginPage = homeUtil.checkLoginPage.bind(homeUtil);
export const openUserProfile = homeUtil.openUserProfile.bind(homeUtil);
export const fixturesRoot: string = testUtils.fixturesRoot; export const fixturesRoot: string = testUtils.fixturesRoot;
@ -1613,6 +1612,14 @@ export function addSamplesForSuite() {
}); });
} }
export async function openUserProfile() {
await driver.findWait('.test-dm-account', 1000).click();
// Since the AccountWidget loads orgs and the user data asynchronously, the menu
// can expand itself causing the click to land on a wrong button.
await waitForServer();
await driver.findContent('.grist-floating-menu li', 'Profile Settings').click();
await driver.findWait('.test-login-method', 5000);
}
} // end of namespace gristUtils } // end of namespace gristUtils

6
test/nbrowser/homeUtil.ts
View File

@ -243,12 +243,6 @@ export class HomeUtil {
); );
} }
public async openUserProfile() {
await this.driver.findWait('.test-dm-account', 1000).click();
await this.driver.findContent('.grist-floating-menu li', 'Profile Settings').click();
await this.driver.findWait('.test-login-method', 5000);
}
/** /**
* Returns whether we are currently on the Cognito login page. * Returns whether we are currently on the Cognito login page.
*/ */