Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fix regression that caused Date/DateTime series to be treated as categorical data

Browse Source 
Test Plan: Tested manually with a Date and DateTime column type.

Reviewers: paulfitz

Reviewed By: paulfitz

Subscribers: paulfitz

Differential Revision: https://phab.getgrist.com/D4305
This commit is contained in:
Dmitry S 2024-07-29 11:45:45 -07:00
parent 61942f6f4b
commit bb0213ecbe
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/client/components/ChartView.ts
View File

@ -78,6 +78,9 @@ export function isNumericLike(col: ColumnRec, use: UseCB = unwrap) {
return ['Numeric', 'Int', 'Any'].includes(colType); return ['Numeric', 'Int', 'Any'].includes(colType);
} }
function isCategoryType(pureType: string): boolean {
return !['Numeric', 'Int', 'Any', 'Date', 'DateTime'].includes(pureType);
}
interface ChartOptions { interface ChartOptions {
multiseries?: boolean; multiseries?: boolean;
@ -1125,7 +1128,7 @@ export const chartTypes: {[name: string]: ChartFunc} = {
bar(series: Series[], options: ChartOptions): PlotData { bar(series: Series[], options: ChartOptions): PlotData {
// If the X axis is not from numerical column, treat it as category. // If the X axis is not from numerical column, treat it as category.
const data = basicPlot(series, options, {type: 'bar'}); const data = basicPlot(series, options, {type: 'bar'});
const useCategory = series[0]?.pureType && !['Numeric', 'Int', 'Any'].includes(series[0].pureType); const useCategory = series[0]?.pureType && isCategoryType(series[0].pureType);
const xaxisName = options.orientation === 'h' ? 'yaxis' : 'xaxis'; const xaxisName = options.orientation === 'h' ? 'yaxis' : 'xaxis';
if (useCategory && data.layout && data.layout[xaxisName]) { if (useCategory && data.layout && data.layout[xaxisName]) {
const axisConfig = data.layout[xaxisName]!; const axisConfig = data.layout[xaxisName]!;