Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) Add sign-up and sharing/invite telemetry

Browse Source 
Summary:
Enhances sign-up telemetry with login and verification method metadata, and
adds UTM parameters to SendGrid invite email links and Grist document links.

Test Plan: Server and manual.

Reviewers: dsagal

Reviewed By: dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D4169
This commit is contained in:
George Gevoian
2024-01-23 20:12:46 -08:00
parent dba3a59486
commit b77c762358
5 changed files with 28 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/gen-server/ApiServerAccess.ts
View File

@@ -144,7 +144,7 @@ describe('ApiServerAccess', function() {
// We should send mail about this one, since Kiwi had no access previously.
if (notificationsConfig) {
const mail = await assertLastMail();
assert.match(mail.description, /^invite kiwi@getgrist.com to http.*\/o\/docs\/$/);
assert.match(mail.description, /^invite kiwi@getgrist.com to http.*\/o\/docs\/\?utm_id=invite-org$/);
const env = mail.payload.personalizations[0].dynamic_template_data;
assert.deepEqual(pick(env, ['resource.name', 'resource.kind', 'resource.kindUpperFirst',
'resource.isTeamSite', 'resource.isWorkspace', 'resource.isDocument',
@@ -159,7 +159,7 @@ describe('ApiServerAccess', function() {
user: {name: 'Kiwi', email: 'kiwi@getgrist.com'},
access: {role: 'editors', canEdit: true, canView: true}
} as any);
assert.match(env.resource.url, /^http.*\/o\/docs\/$/);
assert.match(env.resource.url, /^http.*\/o\/docs\/\?utm_id=invite-org$/);
assert.deepEqual(mail.payload.personalizations[0].to[0], {email: 'kiwi@getgrist.com', name: 'Kiwi'});
assert.deepEqual(mail.payload.from, {email: 'support@getgrist.com', name: 'Chimpy (via Grist)'});
assert.deepEqual(mail.payload.reply_to, {email: 'chimpy@getgrist.com', name: 'Chimpy'});
@@ -207,7 +207,10 @@ describe('ApiServerAccess', function() {
const resp4 = await axios.patch(`${homeUrl}/api/orgs/${nasaOrgId}/access`, {delta: delta4}, chimpy);
assert.equal(resp4.status, 200);
if (notificationsConfig) {
assert.match((await assertLastMail()).description, /^invite kiwi@getgrist.com to http.*\/o\/nasa\/$/);
assert.match(
(await assertLastMail()).description,
/^invite kiwi@getgrist.com to http.*\/o\/nasa\/\?utm_id=invite-org$/
);
}
// Assert that the number of users in the org has updated (Kiwi was added).
assert.deepEqual(userCountUpdates[nasaOrgId as number], [2]);
@@ -349,9 +352,9 @@ describe('ApiServerAccess', function() {
// Check we would sent an email to Kiwi about this
if (notificationsConfig) {
const mail = await assertLastMail();
assert.match(mail.description, /^invite kiwi@getgrist.com to http.*\/o\/docs\/ws\/[0-9]+\/$/);
assert.match(mail.description, /^invite kiwi@getgrist.com to http.*\/o\/docs\/ws\/[0-9]+\/\?utm_id=invite-ws$/);
const env = mail.payload.personalizations[0].dynamic_template_data;
assert.match(env.resource.url, /^http.*\/o\/docs\/ws\/[0-9]+\/$/);
assert.match(env.resource.url, /^http.*\/o\/docs\/ws\/[0-9]+\/\?utm_id=invite-ws$/);
assert.equal(env.resource.kind, 'workspace');
assert.equal(env.resource.kindUpperFirst, 'Workspace');
assert.equal(env.resource.isTeamSite, false);