mirror of
https://github.com/gristlabs/grist-core.git
synced 2024-10-27 20:44:07 +00:00
(core) Increases readability of column filter menu code
Summary: The `select-all` originally designed the `All` button but it unfortunately evolves into designating both `All` and `None`. Which is confusing. Replaces with the more general `bulk-action`. Test Plan: Should not break anything. Reviewers: paulfitz Reviewed By: paulfitz Differential Revision: https://phab.getgrist.com/D2860
This commit is contained in:
parent
b94eb107d4
commit
b740028e8f
@ -114,14 +114,14 @@ export function columnFilterMenu(owner: IDisposableOwner, opts: IFilterMenuOptio
|
||||
dom.text(searchValue ? 'All Shown' : 'All'),
|
||||
cssSelectAll.cls('-disabled', isEquivalentFilter(state, allSpec)),
|
||||
dom.on('click', () => columnFilter.setState(allSpec)),
|
||||
testId('select-all'),
|
||||
testId('bulk-action'),
|
||||
),
|
||||
cssDotSeparator('•'),
|
||||
cssSelectAll(
|
||||
searchValue ? 'All Except' : 'None',
|
||||
cssSelectAll.cls('-disabled', isEquivalentFilter(state, noneSpec)),
|
||||
dom.on('click', () => columnFilter.setState(noneSpec)),
|
||||
testId('select-all'),
|
||||
testId('bulk-action'),
|
||||
)
|
||||
];
|
||||
})
|
||||
|
Loading…
Reference in New Issue
Block a user