mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Fix bug in data engine when records are added after clearing a table with ReplaceTableData.
Summary: It was manifesting as error "docactions.[Bulk]UpdateRecord for non-existent record #1", and due to manualSort column having internal state that wasn't properly cleared. Test Plan: Added a test case that fails without the fix. Reviewers: georgegevoian Reviewed By: georgegevoian Subscribers: georgegevoian Differential Revision: https://phab.getgrist.com/D4183
This commit is contained in:
@@ -2824,9 +2824,12 @@ export async function onNewTab(action: () => Promise<void>) {
|
||||
await driver.executeScript("window.open('about:blank', '_blank')");
|
||||
const tabs = await driver.getAllWindowHandles();
|
||||
await driver.switchTo().window(tabs[tabs.length - 1]);
|
||||
await action();
|
||||
await driver.close();
|
||||
await driver.switchTo().window(tabs[tabs.length - 2]);
|
||||
try {
|
||||
await action();
|
||||
} finally {
|
||||
await driver.close();
|
||||
await driver.switchTo().window(tabs[tabs.length - 2]);
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user