mirror of
https://github.com/gristlabs/grist-core.git
synced 2026-03-02 04:09:24 +00:00
(core) Summary columns improvemnt.
Summary: Improving user experience on summary columns. - Showing 'not-allowed' cursor on sections/menus that can't be changed - Disabling menu options and buttons in the column behavior section that converts a formula column to a data column - Showing nicer error message about converting formula to a data column. Test Plan: manual tests, no behavior change Reviewers: georgegevoian Reviewed By: georgegevoian Differential Revision: https://phab.getgrist.com/D3222
This commit is contained in:
@@ -1,4 +1,5 @@
|
||||
import {IToken, TokenField} from 'app/client/lib/TokenField';
|
||||
import {cssBlockedCursor} from 'app/client/ui/RightPanel';
|
||||
import {basicButton, primaryButton} from 'app/client/ui2018/buttons';
|
||||
import {colorButton} from 'app/client/ui2018/ColorSelect';
|
||||
import {colors, testId} from 'app/client/ui2018/cssVars';
|
||||
@@ -156,6 +157,7 @@ export class ChoiceListEntry extends Disposable {
|
||||
|
||||
return cssVerticalFlex(
|
||||
cssListBoxInactive(
|
||||
dom.cls(cssBlockedCursor.className, this._disabled),
|
||||
dom.autoDispose(someValues),
|
||||
dom.maybe(use => use(someValues).length === 0, () =>
|
||||
row('No choices configured')
|
||||
@@ -372,11 +374,11 @@ const cssListBoxInactive = styled(cssListBox, `
|
||||
cursor: pointer;
|
||||
border: 1px solid ${colors.darkGrey};
|
||||
|
||||
&:hover {
|
||||
&:hover:not(&-disabled) {
|
||||
border: 1px solid ${colors.hover};
|
||||
}
|
||||
&-disabled {
|
||||
cursor: default;
|
||||
opacity: 0.6;
|
||||
}
|
||||
`);
|
||||
|
||||
|
||||
@@ -14,7 +14,7 @@ import { DataRowModel } from 'app/client/models/DataRowModel';
|
||||
import { ColumnRec, DocModel, ViewFieldRec } from 'app/client/models/DocModel';
|
||||
import { SaveableObjObservable, setSaveValue } from 'app/client/models/modelUtil';
|
||||
import { FieldSettingsMenu } from 'app/client/ui/FieldMenus';
|
||||
import { cssLabel, cssRow } from 'app/client/ui/RightPanel';
|
||||
import { cssBlockedCursor, cssLabel, cssRow } from 'app/client/ui/RightPanel';
|
||||
import { buttonSelect } from 'app/client/ui2018/buttonSelect';
|
||||
import { IOptionFull, menu, select } from 'app/client/ui2018/menus';
|
||||
import { DiffBox } from 'app/client/widgets/DiffBox';
|
||||
@@ -228,6 +228,7 @@ export class FieldBuilder extends Disposable {
|
||||
}),
|
||||
testId('type-select'),
|
||||
grainjsDom.cls('tour-type-selector'),
|
||||
grainjsDom.cls(cssBlockedCursor.className, this.origColumn.disableModifyBase)
|
||||
),
|
||||
grainjsDom.maybe((use) => use(this._isRef) && !use(this._isTransformingType), () => this._buildRefTableSelect()),
|
||||
grainjsDom.maybe(this._isTransformingType, () => {
|
||||
|
||||
Reference in New Issue
Block a user