Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

fix: don't count falses in summary (#589)

Browse Source
This commit is contained in:
Vincent Viers 2023-07-26 21:08:04 +02:00 committed by GitHub
parent 71c6537c49
commit ab6807c342
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/components/SelectionSummary.ts
View File

@ -244,7 +244,7 @@ export class SelectionSummary extends Disposable {
} else { } else {
for (const i of rowIndices) { for (const i of rowIndices) {
const value = values[i]; const value = values[i];
if (value !== null && value !== undefined && value !== '' && !isEmpty?.(value)) { if (value !== null && value !== undefined && value !== '' && value !== false && !isEmpty?.(value)) {
countNonEmpty++; countNonEmpty++;
} }
} }

14
test/nbrowser/SelectionSummary.ts
View File

@ -130,11 +130,6 @@ describe('SelectionSummary', function () {
count: 2, count: 2,
sum: null, sum: null,
}); });
await selectAndAssert({col: 2, row: 0}, {col: 3, row: 5}, {
dimensions: '6⨯2',
count: 11,
sum: null,
});
// Scroll horizontally to the end of the table. // Scroll horizontally to the end of the table.
await gu.sendKeys(Key.END); await gu.sendKeys(Key.END);
@ -151,6 +146,15 @@ describe('SelectionSummary', function () {
}); });
}); });
it('does not count false values', async function () {
// False values in boolean columns should not be included in count
await selectAndAssert({col: 2, row: 0}, {col: 3, row: 5}, {
dimensions: '6⨯2',
count: 9,
sum: null,
});
});
it('uses the show column of reference columns for computations', async function () { it('uses the show column of reference columns for computations', async function () {
// Column 6 is a Reference column pointing to column 0. // Column 6 is a Reference column pointing to column 0.
await gu.sendKeys(Key.HOME); await gu.sendKeys(Key.HOME);