Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) New document settings page

Browse Source 
Summary:
This diff implement new page for document settings which replaces the old modal settings.
Diff also adds a new `Settings + API` page item below tools in the left panel that link to that very doc settings page.

Test Plan: Updated existing tests.

Reviewers: jarek

Reviewed By: jarek

Differential Revision: https://phab.getgrist.com/D3761
This commit is contained in:
Cyprien P
2023-01-05 09:11:54 +01:00
parent ca5ae6fa3f
commit a8827b152e
8 changed files with 142 additions and 102 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/client/ui/AccountWidget.ts
View File

@@ -1,4 +1,3 @@
import {loadGristDoc} from 'app/client/lib/imports';
import {AppModel} from 'app/client/models/AppModel';
import {DocPageModel} from 'app/client/models/DocPageModel';
import {getLoginOrSignupUrl, getLoginUrl, getLogoutUrl, urlState} from 'app/client/models/gristUrlState';
@@ -52,14 +51,13 @@ export class AccountWidget extends Disposable {
*/
private _makeAccountMenu(user: FullUser|null): DomElementArg[] {
const currentOrg = this._appModel.currentOrg;
const gristDoc = this._docPageModel ? this._docPageModel.gristDoc.get() : null;
// The 'Document Settings' item, when there is an open document.
const documentSettingsItem = (gristDoc ?
menuItem(async () => (await loadGristDoc()).showDocSettingsModal(gristDoc.docInfo, this._docPageModel!),
t("Document Settings"),
testId('dm-doc-settings')) :
null);
const documentSettingsItem = this._docPageModel ? menuItemLink(
urlState().setLinkUrl({docPage: 'settings'}),
t("Document Settings"),
testId('dm-doc-settings')
) : null;
// The item to toggle mobile mode (presence of viewport meta tag).
const mobileModeToggle = menuItem(viewport.toggleViewport,