tests ADDED

This commit is contained in:
Grégoire Cutzach 2024-08-27 16:08:00 +02:00
parent 8f83e44b30
commit a3f91999f4
No known key found for this signature in database
GPG Key ID: AA4155BE23C375E6
2 changed files with 201 additions and 5 deletions

View File

@ -91,12 +91,16 @@ export class DocSettingsPage extends Disposable {
name: t('Template mode'),
description: t('Special document mode'),
value: cssDocTypeContainer(
dom.create(displayCurrentType, docPageModel.type, /*docPageModel.currentDocId.get()*/),
dom.create(
displayCurrentType,
docPageModel.type,
),
cssSmallButton(t('Edit'),
dom.on('click', this._doSetDocumentType.bind(this, true))
dom.on('click', this._doSetDocumentType.bind(this, true)),
testId('doctype-edit')
)
),
disabled: isDocEditor ? false : t('Only available to document editors'),
disabled: isDocOwner ? false : t('Only available to document owners'),
}),
]),
@ -390,7 +394,7 @@ export class DocSettingsPage extends Disposable {
return [
cssModalTitle(t(`Change nature of document`)),
documentTypeOptions(),
testId('timing-modal'),
testId('doctype-modal'),
];
});
}
@ -484,7 +488,11 @@ function displayCurrentType(
const typeName = typeList.find(ty => ty.type === typeCode)?.label || typeCode;
return typeName;
});
return dom('div', typeObs.get());
return dom(
'div',
typeObs.get(),
testId('doctype-value')
);
}
const cssContainer = styled('div', `

View File

@ -0,0 +1,188 @@
import { UserAPI } from "app/common/UserAPI";
import { assert, driver } from "mocha-webdriver";
import * as gu from "test/nbrowser/gristUtils";
import { setupTestSuite } from "test/nbrowser/testUtils";
describe("Document Type Conversion", function () {
this.timeout(20000);
const cleanup = setupTestSuite();
let userApi: UserAPI;
let docId: string;
let session: gu.Session;
before(async () => {
session = await gu.session().teamSite.login();
docId = await session.tempNewDoc(cleanup);
userApi = session.createHomeApi();
});
async function assertExists() {
await gu.waitToPass(async () => {
assert.equal(await editButton.element().getText(), "Edit");
});
assert.isTrue(await editButton.visible());
}
async function convert(from:String, to:String) {
await gu.openDocumentSettings();
// Check that Document type is from before any conversion was ever apply to It.
assert.equal(await displayedLabel.element().getText(), from);
// Wait for modal.
await modal.wait();
let option;
switch (to) {
case "Regular":
option = optionRegular;
break;
case "Template":
option = optionTemplate;
break;
case "Tutorial":
option = optionTutorial;
break;
}
// Select the template option
await option?.click();
assert.isTrue(await option?.checked());
// Confirm the choice
await modalConfirm.click();
// await for the page reload
await driver.navigate().refresh();
// check that the displayedLabel is now equal to convert destination
assert.equal(await displayedLabel.element().getText(), to);
}
it("should allow to convert from a document type to another", async function () {
await gu.openDocumentSettings();
// Make sure we see the Edit button of document type conversion.
await assertExists();
// Check that Document type is Regular before any conversion was ever apply to It.
assert.equal(await displayedLabel.element().getText(), "Regular");
await editButton.click();
// Wait for modal.
await modal.wait();
// We have three options.
assert.isTrue(await optionRegular.visible());
assert.isTrue(await optionTemplate.visible());
assert.isTrue(await optionTutorial.visible());
// Regular is selected cause its the current mode.
assert.isTrue(await optionRegular.checked());
assert.isFalse(await optionTemplate.checked());
assert.isFalse(await optionTutorial.checked());
// check that cancel works
await modalCancel.click();
assert.isFalse(await modal.present());
});
// If the next six tests succeed so each document type can properly be converted to every other
it('should convert from Regular to Template', async function() {
convert("Regular", "Template");
});
it('should convert from Template to Tutorial', async function() {
convert("Template", "Tutorial");
});
it('should convert from Tutorial to Regular', async function() {
convert("Tutorial", "Regular");
});
it('should convert from Regular to Tutorial', async function() {
convert("Regular", "Tutorial");
});
it('should convert from Tutorial to Template', async function() {
convert("Tutorial", "Template");
});
it('should convert from Template to Regular', async function() {
convert("Template", "Regular");
});
it('should be disabled for non-owners', async function() {
await userApi.updateDocPermissions(docId, {users: {
[gu.translateUser('user2').email]: 'editors',
}});
const session = await gu.session().teamSite.user('user2').login();
await session.loadDoc(`/doc/${docId}`);
await driver.sleep(500);
await gu.openDocumentSettings();
const start = driver.find('.test-settings-doctype-edit');
assert.equal(await start.isPresent(), true);
// Check that we have an informative tooltip.
await start.mouseMove();
assert.match(await driver.findWait('.test-tooltip', 2000).getText(), /Only available to document owners/);
// Nothing should happen on click. We click the location rather than the element, since the
// element isn't actually clickable.
await start.mouseMove();
await driver.withActions(a => a.press().release());
await driver.sleep(100);
assert.equal(await driver.find(".test-settings-doctype-modal").isPresent(), false);
});
});
const element = (testId: string) => ({
element() {
return driver.find(testId);
},
async wait() {
await driver.findWait(testId, 1000);
},
async visible() {
return await this.element().isDisplayed();
},
async present() {
return await this.element().isPresent();
}
});
const label = (testId: string) => ({
...element(testId),
async text() {
return this.element().getText();
},
});
const button = (testId: string) => ({
...element(testId),
async click() {
await gu.scrollIntoView(this.element());
await this.element().click();
},
});
const option = (testId: string) => ({
...button(testId),
async checked() {
return 'true' === await this.element().findClosest("label").find("input[type='checkbox']").getAttribute('checked');
}
});
const editButton = button('.test-settings-doctype-edit');
const displayedLabel = label(".test-settings-doctype-value");
const modal = element(".test-settings-doctype-modal");
const optionRegular = option('.test-settings-doctype-modal-option-regular');
const optionTemplate = option('.test-settings-doctype-modal-option-template');
const optionTutorial = option('.test-settings-doctype-modal-option-tutorial');
const modalConfirm = button('.test-settings-doctype-modal-confirm');
const modalCancel = button('.test-settings-doctype-modal-cancel');