Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Strip invalid characters from table name in excel import

Browse Source 
Summary: Add sanitizeWorksheetName function, pass result to library function addWorksheet where error was raised.

Test Plan: Added unit test for sanitizeWorksheetName function, updated a fixture document to use a messy table name.

Reviewers: dsagal

Reviewed By: dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D3072
This commit is contained in:
Alex Hall 2021-10-11 17:19:34 +02:00
parent a64fb105e3
commit 9d1cc89dc9
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
app/server/lib/ExportXLSX.ts
View File

@ -88,7 +88,7 @@ async function convertToExcel(tables: ExportData[], testDates: boolean) {
}; };
for (const table of tables) { for (const table of tables) {
const { columns, rowIds, access, tableName } = table; const { columns, rowIds, access, tableName } = table;
const ws = wb.addWorksheet(tableName); const ws = wb.addWorksheet(sanitizeWorksheetName(tableName));
// Build excel formatters. // Build excel formatters.
const formatters = columns.map(col => createExcelFormatter(col.type, col.widgetOptions)); const formatters = columns.map(col => createExcelFormatter(col.type, col.widgetOptions));
// Generate headers for all columns with correct styles for whole column. // Generate headers for all columns with correct styles for whole column.
@ -120,3 +120,19 @@ async function convertToExcel(tables: ExportData[], testDates: boolean) {
return await wb.xlsx.writeBuffer(); return await wb.xlsx.writeBuffer();
} }
/**
* Removes invalid characters, see https://github.com/exceljs/exceljs/pull/1484
*/
export function sanitizeWorksheetName(tableName: string): string {
return tableName
// Convert invalid characters to spaces
.replace(/[*?:/\\[\]]/g, ' ')
// Collapse multiple spaces into one
.replace(/\s+/g, ' ')
// Trim spaces and single quotes from the ends
.replace(/^['\s]+/, '')
.replace(/['\s]+$/, '');
}