Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2024-10-27 20:44:07 +00:00
Code Issues Projects Releases Wiki Activity

(core) Fixing bug on a fresh Choice and ChoiceList column

Browse Source 
Summary: Adding a new element to a new Choice or ChoiceList column resulted in javascript error

Test Plan: Browser tests

Reviewers: georgegevoian, dsagal

Reviewed By: georgegevoian, dsagal

Subscribers: dsagal

Differential Revision: https://phab.getgrist.com/D2932
This commit is contained in:
Jarosław Sadziński 2021-07-21 12:59:45 +02:00
parent f5981606e1
commit 9cc034f606
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/client/widgets/ChoiceEditor.js
View File

@ -80,7 +80,7 @@ ChoiceEditor.prototype.prepForSave = async function() {
const selectedItem = this.autocomplete && this.autocomplete.getSelectedItem();
if (selectedItem && selectedItem.isNew) {
const choices = this.options.field.widgetOptionsJson.prop('choices');
await choices.saveOnly([...choices.peek(), selectedItem.label]);
await choices.saveOnly([...(choices.peek() || []), selectedItem.label]);
}
}

2
app/client/widgets/ChoiceListEditor.ts
View File

@ -157,7 +157,7 @@ export class ChoiceListEditor extends NewBaseEditor {
const newChoices = tokens.filter(t => t.isNew).map(t => t.label);
if (newChoices.length > 0) {
const choices = this.options.field.widgetOptionsJson.prop('choices');
await choices.saveOnly([...choices.peek(), ...new Set(newChoices)]);
await choices.saveOnly([...(choices.peek() || []), ...new Set(newChoices)]);
}
}