Archives/gristlabs_grist-core
1
0
Fork 0
mirror of https://github.com/gristlabs/grist-core.git synced 2026-03-02 04:09:24 +00:00
Code Issues Projects Releases Wiki Activity

(core) Bundling save funciton in the field editor

Browse Source 
Summary:
Some editors do some async work before saving the value (Ref column can add new
records). Those actions were send without bundling, so it wasn't possible to undo those
actions with togheter.

Test Plan: Added new test

Reviewers: georgegevoian

Reviewed By: georgegevoian

Differential Revision: https://phab.getgrist.com/D4285
This commit is contained in:
Jarosław Sadziński
2024-07-04 14:27:49 +02:00
parent 7f28aee79c
commit 9c4814e7aa
2 changed files with 84 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
test/nbrowser/ReferenceList.ts
View File

@@ -13,6 +13,41 @@ describe('ReferenceList', function() {
});
describe('other', function() {
it('fix: changing ref list with a new referenced row was not bundled', async function() {
// When user added a new referenced row through the RefList editor, the UI sent two separate
// actions. One for adding the new row, and another for updating the RefList column.
await session.tempNewDoc(cleanup);
await gu.sendActions([
['ModifyColumn', 'Table1', 'B', {type: 'RefList:Table1'}],
['AddRecord', 'Table1', null, {A: 'a'}],
]);
await gu.openColumnPanel();
await gu.getCell('B', 1).doClick();
await gu.setRefShowColumn('A');
await gu.getCell('B', 1).click();
await gu.sendKeys(Key.ENTER, 'b');
await gu.waitToPass(async () => {
await driver.findWait('.test-ref-editor-new-item', 100).click();
});
await gu.sendKeys(Key.ENTER);
await gu.waitForServer();
// Check the data - use waitToPass helper, as previously it might have failed
// as 2 separate actions were sent.
await gu.waitToPass(async () => {
assert.deepEqual(await gu.getVisibleGridCells('A', [1, 2]), ['a', 'b']);
assert.deepEqual(await gu.getVisibleGridCells('B', [1, 2]), ['b', '']);
assert.equal(await gu.getGridRowCount(), 3);
});
// Now press undo once, and check that the new row is removed and the RefList is updated.
await gu.undo();
assert.deepEqual(await gu.getVisibleGridCells('A', [1]), ['a']);
assert.deepEqual(await gu.getVisibleGridCells('B', [1]), ['']);
assert.equal(await gu.getGridRowCount(), 2);
});
it('fix: doesnt break when table is renamed', async function() {
// There was a bug in this scenario:
// 1. Create a Ref column that targets itself